Re: Log4net website issue

2017-04-18 Thread Dominik Psenner
I like the idea to generate parts of the website with stuff that comes from the source code. However I can't see how the different sources could all be assembled together. The sdk reference is already generated from source, however that is already one step to far because we won't get the styles

PR#72 build failure.

2017-04-18 Thread Chandra
Hi List, I had a minor update on the documentation for which I sent a pull request. Not sure what happened but, the travis build failed. I see a lot of build failures from the PRs, any reason for that? Here’s my pull request. https://github.com/apache/logging-log4j2/pull/72 thanks, Chandra

[jira] [Commented] (LOG4J2-1877) Missing documentation for Max index limit in DefaultRolloverStrategy

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974087#comment-15974087 ] ASF GitHub Bot commented on LOG4J2-1877: GitHub user tckb opened a pull request:

Re: Log4net website issue

2017-04-18 Thread Remko Popma
Asciidoc is much nicer than anything one can do in javadoc. Sent from my iPhone > On Apr 19, 2017, at 10:10, Gary Gregory wrote: > > Maybe from package level Javadocs? > > Gary > >> On Apr 18, 2017 5:56 PM, "Remko Popma" wrote: >> >> Asciidoc can include code snippets or whole files: >> ht

Re: Log4net website issue

2017-04-18 Thread Gary Gregory
Maybe from package level Javadocs? Gary On Apr 18, 2017 5:56 PM, "Remko Popma" wrote: > Asciidoc can include code snippets or whole files: > http://asciidoctor.org/docs/user-manual/#include-partial > > I'm not convinced that it's desirable to generate the user manual from > javadoc though. They

Re: Log4net website issue

2017-04-18 Thread Remko Popma
Asciidoc can include code snippets or whole files: http://asciidoctor.org/docs/user-manual/#include-partial I'm not convinced that it's desirable to generate the user manual from javadoc though. They usually target different audiences so the content is different. Sent from my iPhone > On Apr

Re: Log4net website issue

2017-04-18 Thread Gary Gregory
When I worked on my Hibernate book, we had a system that would extract text out of source files into the xhtml book source. All of the examples in the book come from real code that gets compiled and tested before the book is built. So it is all doable. Gary On Apr 18, 2017 4:37 PM, "Matt Sicker"

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973759#comment-15973759 ] Ralph Goers commented on LOG4J2-1887: - The issue would arise if someone is using a Nu

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973752#comment-15973752 ] Matt Sicker commented on LOG4J2-1887: - The whole point of NullConfiguration was to av

[jira] [Commented] (LOG4J2-1858) Memory issues with ParameterizedMessage

2017-04-18 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973747#comment-15973747 ] Matt Sicker commented on LOG4J2-1858: - Considering we just released 2.8.2 last week,

[jira] [Commented] (LOG4J2-1883) Timestamp does not seem to support microseconds level

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973743#comment-15973743 ] Ralph Goers commented on LOG4J2-1883: - That is unlikely to help. The Clock object was

Re: [log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Matt Sicker
+1, go git, go On 18 April 2017 at 10:33, Gary Gregory wrote: > +1, note that this kind of vote could be a "lazy" vote IMO. > > Gary > > On Apr 18, 2017 5:37 AM, "Dominik Psenner" wrote: > > > This is a vote to migrate the source code of the log4net subproject from > > subversion over to git. >

Re: Log4net website issue

2017-04-18 Thread Matt Sicker
We have a similar issue in Log4j right now where documentation is mainly maintained in the manual pages, but there are javadocs as well. Ideally, I'd like to be able to generate the manual pages from the javadocs, but I haven't really looked into how to do that yet. I've seen such a pattern used wi

[jira] [Commented] (LOG4J2-1883) Timestamp does not seem to support microseconds level

2017-04-18 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973726#comment-15973726 ] Gary Gregory commented on LOG4J2-1883: -- Java 8's {{java.time.Instant.getNano()}} cou

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973610#comment-15973610 ] Gary Gregory commented on LOG4J2-1887: -- Ah, yes, well, that would work but would sti

Re: [jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Shivinder Singh
Hello everyone, How do I control subscription to this list? Something has changed in the past week or so. "Ralph Goers (JIRA)" wrote: [ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973433#comment

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973564#comment-15973564 ] Ralph Goers commented on LOG4J2-1887: - What could possibly break is user code that is

[jira] [Closed] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers closed LOG4J2-1887. --- Resolution: Not A Problem Closing per reporter. > A FileDescriptor that points to a log file is neve

Re: [Scala][VOTE] Release log4j-api-scala 11.0 rc1

2017-04-18 Thread Matt Sicker
I've had the opposite problem at work before where a jar published from SBT wasn't giving transitive dependencies in Gradle. I blame Ivy. On Tue, Apr 18, 2017 at 02:25, Mikael Ståldal wrote: > I just tested this, and it works. But I encountered one issue, when testing > from an SBT project, the

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973522#comment-15973522 ] Gary Gregory commented on LOG4J2-1887: -- Having NullConfiguration immutable from the

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973508#comment-15973508 ] Facundo Velazquez commented on LOG4J2-1887: --- I understand. So i should check ad

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973482#comment-15973482 ] Ralph Goers edited comment on LOG4J2-1887 at 4/18/17 8:58 PM: -

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973482#comment-15973482 ] Ralph Goers edited comment on LOG4J2-1887 at 4/18/17 8:57 PM: -

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973482#comment-15973482 ] Ralph Goers commented on LOG4J2-1887: - Nothing should be adding appenders to the Null

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973454#comment-15973454 ] Ralph Goers edited comment on LOG4J2-1887 at 4/18/17 8:53 PM: -

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973454#comment-15973454 ] Facundo Velazquez edited comment on LOG4J2-1887 at 4/18/17 8:47 PM: ---

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973454#comment-15973454 ] Facundo Velazquez edited comment on LOG4J2-1887 at 4/18/17 8:45 PM: ---

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973454#comment-15973454 ] Facundo Velazquez edited comment on LOG4J2-1887 at 4/18/17 8:45 PM: ---

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973454#comment-15973454 ] Facundo Velazquez commented on LOG4J2-1887: --- Hi [~ralph_go...@dslextreme.com].

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973433#comment-15973433 ] Ralph Goers edited comment on LOG4J2-1887 at 4/18/17 8:28 PM: -

[jira] [Comment Edited] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973433#comment-15973433 ] Ralph Goers edited comment on LOG4J2-1887 at 4/18/17 8:25 PM: -

[jira] [Commented] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973433#comment-15973433 ] Ralph Goers commented on LOG4J2-1887: - I don't see how the fix you are proposing work

Re: [2/2] logging-log4j2 git commit: LOG4J2-1880 Warn when a configuration file for an inactive ConfigurationFactory is found

2017-04-18 Thread Gary Gregory
On Tue, Apr 18, 2017 at 2:52 AM, Mikael Ståldal wrote: > It is meant to match this message: > > https://git1-us-west.apache.org/repos/asf?p=logging- > log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/ > logging/log4j/core/config/ConfigurationFactory.java;h= > 8b360a56bbd2e0753146ecc337bd73

[jira] [Created] (LOG4J2-1887) A FileDescriptor that points to a log file is never closed.

2017-04-18 Thread Facundo Velazquez (JIRA)
Facundo Velazquez created LOG4J2-1887: - Summary: A FileDescriptor that points to a log file is never closed. Key: LOG4J2-1887 URL: https://issues.apache.org/jira/browse/LOG4J2-1887 Project: Log4j

[jira] [Commented] (LOG4J2-1858) Memory issues with ParameterizedMessage

2017-04-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972951#comment-15972951 ] Adrien Grand commented on LOG4J2-1858: -- I understand release scheduling is hard, but

Re: [log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Gary Gregory
+1, note that this kind of vote could be a "lazy" vote IMO. Gary On Apr 18, 2017 5:37 AM, "Dominik Psenner" wrote: > This is a vote to migrate the source code of the log4net subproject from > subversion over to git. > > [ ] +1, yes let's migrate to git > [ ] 0, I don't care because... > [ ] -1,

Re: Log4net website issue

2017-04-18 Thread Dominik Psenner
Hi, We probably should at least add a remark that points readers to the SDK reference and avoid the double effort of maintaining the documentation on the website too. Cheers, Dominik On 2017-04-18 17:09, Stefan Bodewig wrote: Hi John On 2017-04-18, John V wrote: Please forward this if y

Re: Log4net website issue

2017-04-18 Thread Stefan Bodewig
Hi John On 2017-04-18, John V wrote: > Please forward this if you are not the appropriate recipient. Many thanks! > I was browsing the documentation on the Log4Net website for a list of > all of the formatting flags for the PatternLayout, but could not find > one. I did discover some dead link

Log4net website issue

2017-04-18 Thread John V
Please forward this if you are not the appropriate recipient. I was browsing the documentation on the Log4Net website for a list of all of the formatting flags for the PatternLayout, but could not find one. I did discover some dead links on the manual's introduction page at http://logging.apa

[jira] [Updated] (LOG4J2-1886) Remove logger from configuration using code

2017-04-18 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Izek Greenfield updated LOG4J2-1886: Description: When I add new logger level in runtime (using Spring Actuator API or JMX API)

[jira] [Updated] (LOG4J2-1886) Remove logger from configuration from code

2017-04-18 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Izek Greenfield updated LOG4J2-1886: Description: When I add new logger level in runtime (using Spring Actuator API or JMX API)

[jira] [Updated] (LOG4J2-1886) Remove logger from configuration using code

2017-04-18 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Izek Greenfield updated LOG4J2-1886: Summary: Remove logger from configuration using code (was: Remove logger from configuratio

[jira] [Created] (LOG4J2-1886) Remove logger from configuration from code

2017-04-18 Thread Izek Greenfield (JIRA)
Izek Greenfield created LOG4J2-1886: --- Summary: Remove logger from configuration from code Key: LOG4J2-1886 URL: https://issues.apache.org/jira/browse/LOG4J2-1886 Project: Log4j 2 Issue Type

Re: [log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Mikael Ståldal
0 I don't care because I don't work with that project. On Tue, Apr 18, 2017 at 3:05 PM, Stefan Bodewig wrote: > On 2017-04-18, Dominik Psenner wrote: > > > This is a vote to migrate the source code of the log4net subproject > > from subversion over to git. > > +1 > > Stefan > -- [image: Mag

[jira] [Closed] (LOG4J2-1858) Memory issues with ParameterizedMessage

2017-04-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand closed LOG4J2-1858. The changes look good to me, thank you! > Memory issues with ParameterizedMessage > --

Re: [log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Stefan Bodewig
On 2017-04-18, Dominik Psenner wrote: > This is a vote to migrate the source code of the log4net subproject > from subversion over to git. +1 Stefan

Re: [log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Dominik Psenner
Apologies, just noticed that I had a typo in the vote. Sorry for that. Please apply this patch: - As always, at least 3 + 1s are more +1s than -1s are required. + As always, at least 3 + 1s and more +1s than -1s are required. Dominik 2017-04-18 14:37 GMT+02:00 Dominik Psenner : > This is a vote

[log4net] [VOTE] migrate log4net from svn to git

2017-04-18 Thread Dominik Psenner
This is a vote to migrate the source code of the log4net subproject from subversion over to git. [ ] +1, yes let's migrate to git [ ] 0, I don't care because... [ ] -1, don't migrate to git because... The vote will remain open for 72 hours at least. All votes are welcome and we encourage every

[jira] [Comment Edited] (LOG4J2-1866) Add default value to MdcPatternConverter

2017-04-18 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972576#comment-15972576 ] Izek Greenfield edited comment on LOG4J2-1866 at 4/18/17 12:27 PM:

[jira] [Updated] (LOG4J2-1866) Add default value to MdcPatternConverter

2017-04-18 Thread Izek Greenfield (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Izek Greenfield updated LOG4J2-1866: Attachment: Add_default_value_to_MDC_converter.patch Patch file to add default values > Ad

Re: Feedback request

2017-04-18 Thread Mikael Ståldal
Looks nice! Some feedback: * I don't like to prefix interface names with "I", as you do in ITypeConverter etc. Doing so is common in .Net, but not in Java. * Why does CommandLine.parse() return List? This is not correctly documentated in the Javadoc @return tag. * Maybe CommandLine.usage() coul

Re: [2/2] logging-log4j2 git commit: LOG4J2-1880 Warn when a configuration file for an inactive ConfigurationFactory is found

2017-04-18 Thread Mikael Ståldal
It is meant to match this message: https://git1-us-west.apache.org/repos/asf?p=logging-log4j2.git;a=blob;f=log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java;h=8b360a56bbd2e0753146ecc337bd7317756229b0;hb=HEAD#l523 Is it wise to stuff in more information into a

Re: [Scala][VOTE] Release log4j-api-scala 11.0 rc1

2017-04-18 Thread Mikael Ståldal
I just tested this, and it works. But I encountered one issue, when testing from an SBT project, the transitive dependency for log4j-api did not work, I had to specify log4j-api explicitly. When testing from a Maven project, it worked as expected. Have anyone else tried this from SBT? Is this a bug