[dev] Mention 'tox' generated directory into .gitignore

2012-10-28 Thread Jaume Devesa
Hi, Just a trivial patch. So trivial that I didn't even create a Jira (let me know if it is needed) When run *tox* to check the tests for all python versions, you need to copy the *libcloud/test/secrets.py-dist* into the *libcloud/test/secrets.py* file. I ignore why, can somebody explain me? Any

Re: [dev] Mention 'tox' generated directory into .gitignore

2012-10-28 Thread Tomaž Muraus
Done, thanks! secrets.py was actually already there, but not a long time ago we've moved the test directory from test/ to libcloud/test and forgot to update the .gitignore file. On Sun, Oct 28, 2012 at 5:12 AM, Jaume Devesa wrote: > Hi, > > Just a trivial patch. So trivial that I didn't even cre

Re: [dev] Mention 'tox' generated directory into .gitignore

2012-10-28 Thread Jaume Devesa
Good, thanks! Sorry if I insist but, why we need to copy from 'secrets.py-dist' to 'secrets.py'? Couldn't the file be named 'secrets.py' directly? Maybe the reason is obvious but I can not see it... On 28 October 2012 15:40, Tomaž Muraus wrote: > Done, thanks! > > secrets.py was actually alread

Re: [dev] Mention 'tox' generated directory into .gitignore

2012-10-28 Thread Tomaž Muraus
No problem. The reason is that you can put your actual credentials in the secrets.py file and test it with a real provider. Requiring user to copy secrets.py-dist over to secrets.py makes it harder to edit the wrong file and accidentally check in your real credentials. On Sun, Oct 28, 2012 at 8:

Re: [dev] Mention 'tox' generated directory into .gitignore

2012-10-28 Thread Jaume Devesa
That makes sense now. Thanks. On 28 October 2012 16:34, Tomaž Muraus wrote: > No problem. > > The reason is that you can put your actual credentials in the secrets.py > file and test it with a real provider. > > Requiring user to copy secrets.py-dist over to secrets.py makes it harder > to edit

[dev] [jira] [Commented] (LIBCLOUD-249) This patch adds support for HostVirtual API http://www.vr.org/ (compute and dns driver)

2012-10-28 Thread Tomaz Muraus (JIRA)
[ https://issues.apache.org/jira/browse/LIBCLOUD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485730#comment-13485730 ] Tomaz Muraus commented on LIBCLOUD-249: --- Thanks for the patch. It mostly looks go