Re: Upstreaming 6 commits from Nyrkiö fork

Cool! I sent the PR. Feels good to merge a years worth of divergence :-) On Sun, Jan 5, 2025 at 2:12 AM Alexander Sorokoumov < aleksandr.sorokou...@gmail.com> wrote: > Hey Henrik, > > https://github.com/apache/hunter is online, so you can open a PR against > master! FWIW I double-checked that you

Re: Upstreaming 6 commits from Nyrkiö fork

Hey Henrik, https://github.com/apache/hunter is online, so you can open a PR against master! FWIW I double-checked that your commits did not introduce any changes to Kafka Streams benchmark results. Best, Alex On Tue, Dec 10, 2024 at 6:30 PM Alexander Sorokoumov < aleksandr.sorokou...@gmail.com>

Re: Upstreaming 6 commits from Nyrkiö fork

> Are we planning to complete the "initial clean up" outside of apache/hunter or would we just push what we have and then continue with the cleanup in apache/hunter? Both ways are acceptable. I'd rather get datastax-labs/hunter into apache/hunter, then merge Nyrkiö's changes, then do the clean up

Re: Upstreaming 6 commits from Nyrkiö fork

Ah, now I see what Mick was saying. Cool stuff. Yeah it will be nice to keep old PRs and issues! On Tue, Dec 10, 2024 at 3:58 PM Sean McCarthy wrote: > Apologies, I had linked the wrong ticket. Thanks Mick for sharing the > right issue. > > > On Dec 10, 2024, at 8:26 AM, Henrik Ingo wrote: > >

Re: Upstreaming 6 commits from Nyrkiö fork

Apologies, I had linked the wrong ticket. Thanks Mick for sharing the right issue. > On Dec 10, 2024, at 8:26 AM, Henrik Ingo wrote: > > On Tue, Dec 10, 2024 at 2:43 PM Mick Semb Wever wrote: > >>> The Infra ticket is only about the name of the repo, not the contents. >>> >> >> >> Th

Re: Upstreaming 6 commits from Nyrkiö fork

On Tue, Dec 10, 2024 at 2:43 PM Mick Semb Wever wrote: > > > > > The Infra ticket is only about the name of the repo, not the contents. > > > > > The contents are getting moved. See INFRA-26353 > This'll move issues and PRs over too, and put a redirect in place from the > old url. > Let me know

Re: Upstreaming 6 commits from Nyrkiö fork

On Tue, 10 Dec 2024 at 22:42, Henrik Ingo wrote: > On Mon, Dec 9, 2024 at 5:24 PM Sean McCarthy > wrote: > > > I believe datastax-labs/hunter is being moved into apache/hunter by > > ASF-infra, according to: https://issues.apache.org/jira/browse/HUNTER-1 > < > > https://issues.apache.org/jira/br

Re: Upstreaming 6 commits from Nyrkiö fork

On Mon, Dec 9, 2024 at 5:24 PM Sean McCarthy wrote: > I believe datastax-labs/hunter is being moved into apache/hunter by > ASF-infra, according to: https://issues.apache.org/jira/browse/HUNTER-1 < > https://issues.apache.org/jira/browse/HUNTER-1> > Tracked in https://issues.apache.org/jira/brows

Re: Upstreaming 6 commits from Nyrkiö fork

I believe datastax-labs/hunter is being moved into apache/hunter by ASF-infra, according to: https://issues.apache.org/jira/browse/HUNTER-1 Tracked in https://issues.apache.org/jira/browse/INFRA-26336

Re: Upstreaming 6 commits from Nyrkiö fork

I think we would like https://github.com/datastax-labs/hunter to be ceremoniously pushed as the main branch. Of course, my 6 commits are now rebased on top of it too, but they are more or less new to the rest of the community, so submitting them as separate PRs, or in any case as one single separa

Re: Upstreaming 6 commits from Nyrkiö fork

If you used the Series and AnalyzedSeries classes the p-value fix should not affect you because those classes use an AnalysisOptions object that has is own defaults and I didn't change those. (Rather, my change aligns default arguments later in the call stack with those set in AnalysisOptions.) Bu

Re: Upstreaming 6 commits from Nyrkiö fork

I could help push https://github.com/nyrkio/hunter/tree/to-asf-upstream2 as the main branch in https://github.com/apache/hunter repository if that's what we'd want to have as the starting point. There's an "Initial Clean Up" step described here: https://incubator.apache.org/guides/transitioning_as

Re: Upstreaming 6 commits from Nyrkiö fork

Hi Henrik, Thank you for preparing these commits! I will test them on Kafka Streams benchmark results in the next couple of days. I am especially curious about the p-value fix. Best, Alex On Sun, Dec 8, 2024 at 12:30 PM Henrik Ingo wrote: > Hi all > > I didn't yet receive powers to push the

Upstreaming 6 commits from Nyrkiö fork

Hi all I didn't yet receive powers to push the entire hunter repo into https://github.com/apache/hunter ...and since there isn't any code or branches there, I also cannot create a pull request just yet. But... I did spend this Sunday afternoon preparing a branch that is rebased on top of what I e