Re: [PR] Upstreaming 2024 Nyrkiö patches [hunter]

2025-01-10 Thread Henrik Ingo
I feel like I got First Post on Slashdot On Sat, Jan 11, 2025 at 12:29 AM Dave Fisher wrote: > Projects can choose to operate either by Review Then Commit (RTC) or > Commit Then Review (CTR). > > You’ve satisfied either method. > > Best, > Dave > > > On Jan 10, 2025, at 1:35 PM, Henrik Ingo wro

Re: [PR] Upstreaming 2024 Nyrkiö patches [hunter]

2025-01-10 Thread Dave Fisher
Projects can choose to operate either by Review Then Commit (RTC) or Commit Then Review (CTR). You’ve satisfied either method. Best, Dave > On Jan 10, 2025, at 1:35 PM, Henrik Ingo wrote: > > But thanks. I'm proud to be on the committers and PPMC now - confirming > that it came through. > >

Re: [PR] Upstreaming 2024 Nyrkiö patches [hunter]

2025-01-10 Thread Henrik Ingo
But thanks. I'm proud to be on the committers and PPMC now - confirming that it came through. Now that I finally got one years worth of linting debt back on track... I Alex' approving comment sufficient to press the green Merge button in github? henrik On Fri, Jan 10, 2025 at 11:21 PM henrikingo

Re: [PR] Upstreaming 2024 Nyrkiö patches [hunter]

2025-01-10 Thread Dave Fisher
Henrik, I’ve done my mentor duty and added you to the roster. Allow an hour or so for updates and we will see if additional setup is needed. Best, Dave > On Jan 10, 2025, at 11:24 AM, henrikingo (via GitHub) wrote: > > > henrikingo commented on PR #27: > URL: https://github.com/apache/hunter