Github user davinash commented on the issue:
https://github.com/apache/geode/pull/440
Is this ok to merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/488
GEODE-254: Removed deprecated Region.keys and Region.entries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-254
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/443
closing this PR as per the comment above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/495
GEODE-234: Removed deprecated MirrorType class and its usage is replaced by
appropriate DataPolicy.REPLICATE or DataPolicy.NORMAL
- Did not find cache-9.0.xsd in source. So I am assuming this file
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/464
Some is wrong. I am closing this PR and will raise another one from latest
develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/496
GEODE-237: Removed deprecated API from EntryEvent
@upthewaterspout , @dschneider-pivotal
Resubmitting PR , as I have closed #464
Please review.
You can merge this pull request into a Git
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/467
Thanks @kirklund and @upthewaterspout If I understand correctly
getLoggerI18n should go away and replace with Log4j2. What is to be done for
getSecurityLoggerI18n ??
---
If your project is set up
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/495
Thanks @dschneider-pivotal for the review.
Do you want CacheXML and dtd changes part of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/488
Thanks @dschneider-pivotal for review. I will fix those issue and raise
another PR, as this one is already merged.
---
If your project is set up for it, you can reply to this email and have your
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/497
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/504
GEODE-254: Removed deprecated Region.keys and Region.entries
Addressing review comment from
https://github.com/apache/geode/pull/488
- removed method entries
- IndexMaintenanceJUnitTest
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/504
Thanks @dschneider-pivotal Can I merge this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/508
@prasi-in Can you please fix the imports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/515
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/529
GEODE-2980: All the methods in an interface are implicitly public and
abstract.
All fields in the interface are implicitly public, static and final.
Removing this from all the interface
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/529
Thanks @kirklund , Yes Please you can merge this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/529
Hi @kirklund Updated the PR and running the tests now again. Please review
and you can merge the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/467
Thanks @kirklund and @upthewaterspout for your comments. I am moving this
discussion on JIRA GEODE-258 and more questions.
---
If your project is set up for it, you can reply to this email and
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/388
GEODE-2428: Adding support of Serialization/deserialization of LinkedHashMap
Added support for writeLinkedHashMap and readLinkedHashMap and the test for
the same.
You can merge this pull request
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/329
closing this one and will open another PR for the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/390
[GEODE-1887] #comment Fix Issue Client PROXY region should delegate all
operations to server
Issue : Client PROXY region should delegate all operations to server
If client and data policy
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/390
Thanks @sbawaska for review. I have made the changes. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash commented on the issue:
https://github.com/apache/geode-native/pull/21
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/388
Thanks @metatype and @bschuchardt
I will fix import issue and check-in the changes to develop, once all the
checks have passed.
---
If your project is set up for it, you can reply to this
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070526
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070521
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070525
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/390
Thanks @kirklund
Addressed review comment. Please let me know if this is PR is now good for
merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
@metatype , @dschneider-pivotal Please let me know if this is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/388
Closing, merged to develop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/440
GEODE-2723: Removed localCacheEnabled field, and associated dead code.
- Removed localCacheEnabled field, and associated dead code.
- Ran pre-checkin, no failures.
You can merge this pull
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/443
[GEODE-1887] #comment Fix for Client PROXY region should delegate all
operations to server
Fix for Client PROXY region should delegate all operations to server
- Resubmitting the PR
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/450
+1. @kirklund what is correct way of running those benchmark. Is following
command correct
./gradlew :geode-core:jmh
---
If your project is set up for it, you can reply to this email and have
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/456
GEODE-72 : Remove deprecated APIs from Geode
This PR fixes following
- GEODE-236 Remove deprecated CacheEvent methods
- GEODE-237 Remove EntryEvent deprecated methods
- GEODE-253
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/456
@kirklund , I will create separate PR for each JIRA and then will close
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/463
GEODE-236: Removed deprecated CacheEvent methods
Removed deprecated CacheEvent methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/464
GEODE-237: Removed deprecated API from EntryEvent
Removed deprecated CacheEvent methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/465
GEODE-253: Removed depreated and not used EntryNotFoundInRegion class
Removed depreated and not used EntryNotFoundInRegion class
You can merge this pull request into a Git repository by running
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/466
GEODE-255: Removed deprecated DataSerializer.register(Class,byte)
Removed deprecated DataSerializer.register(Class,byte)
You can merge this pull request into a Git repository by running:
$ git
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/467
GEODE-258: Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n
methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/468
GEODE-260: Remove deprecated RemoteTransactionException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-260
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/469
GEODE-266: Remove the deprecated ObjectSizerImpl class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-266
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/470
GEODE-267: Remove deprecated ThreadInterruptedException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-267
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/471
GEODE-289: Remove depcreated LicenseException class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-289
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/456
closing this PR, as I have opened separate PR for each subtask.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/469
Is this PR OK to merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/468
Thanks @upthewaterspout for review
Is this PR OK to merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/466
Thanks @upthewaterspout for review
Is this PR OK to merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/465
Thanks @upthewaterspout for review
Is this PR OK to merge ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/291
[GEODE-1122] Fixed Dependency on environment variable GEMFIRE needs to be
removed
All Test Passing.
You can merge this pull request into a Git repository by running:
$ git pull
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781673
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java ---
@@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781680
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
---
@@ -146,6
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
Thanks for Review @metatype
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781685
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1493,6 +1495,7
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
Is this PR now good for merge to develop now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/295
[GEODE-1984] #comment Fix Issue Make GatewaySender destroy a public API
1. Making destory API public
2. Added a new gfsh WAN command destroyGatewaySender
3. Impleted
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/291
@metatype Thanks for the review,
I think I messed up in my local git repo. I am always getting
```
~/source/open/incubator-geode (feature/GEODE-1122) $ git flow feature
finish
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/298
@metatype I have re-created a Pull Request and closed the earlier one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/298
[GEODE-1122] Fix Dependency on environment variable GEMFIRE needs to be
removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/298
This closes #298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/299
[ GEODE-2141 ] #comment Fix Issue #2141
Replaced List with ConcurrentHashSet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/283
closing the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/299
Thanks @upthewaterspout , @metatype for review
I Have address review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/299
Is this PR good to merge to develop ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user davinash closed the pull request at:
https://github.com/apache/incubator-geode/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/295
Hi @metatype Could you please deleting branch GEODE-1984 from master. I am
getting error.
git flow feature start GEODE-1984
Fatal: Branch 'feature/GEODE-1984' already ex
Github user davinash commented on the issue:
https://github.com/apache/incubator-geode/pull/295
I have no problem with write access and have deleted local branch. But I
get following error.
```
git push origin --delete feature/GEODE-1984
error: unable to delete 'fe
GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/303
GEODE-1984: Fix Issue Make GatewaySender destroy a public API
1. Making destory API public
2. Added a new gfsh WAN command destroyGatewaySender
3. Impleted
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/303
Please help to review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91421904
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
@@ -400,4 +400,19 @@
public int
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422055
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -55,7 +55,7
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422209
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ---
@@ -400,4 +400,19 @@
public int
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422194
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderDestroyFunction.java
---
@@ -0,0 +1,90
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91458212
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -282,13 +335,40
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/303
Thanks @upthewaterspout , @jhuynh1 for review.
I have address comments. Please let me know now if this PR OK to merge.
---
If your project is set up for it, you can reply to this email and have
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/312
[GEODE-2061] Fix for Remove PdxInstanceInputStream
- Removed PdxInstanceInputStream
- Removed usage of PdxInstanceInputStream and replace with PdxInputStream
You can merge this pull request
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/312
CC @bschuchardt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/315
GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactoryâ¦
â¦, ReliableMessageQueueFactoryImpl and
it's usage in the code from GemfireCacheImpl and DistributedR
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Please review this PR, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/319
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/322
[GEODE-165] Fix for Add build support for generating antlr classes from
grammar
1. Updated spotless configuration to exclude 'generated-src' directory.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Thanks @dschneider-pivotal for review, I will make these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
All test passed. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/322
Thanks @upthewaterspout , Is this PR good for merge to develop now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Is this PR looking good now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/329
[GEODE-1887] #comment Fix for Issue #1887
Issue : Client PROXY region should delegate all operations to server
1. If client and data policy is empty then size API goes through
1 - 100 of 108 matches
Mail list logo
