[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...

2017-05-22 Thread AkihiroKitada
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/525 GEODE-2962: Add more messages for compact disk-store Added a message in the case that notExecutedMembers variable is null. Thank you for submitting a contribution to Apache Geode

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-22 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Do I need write test code for this minor change? If so, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...

2017-05-23 Thread AkihiroKitada
Github user AkihiroKitada commented on a diff in the pull request: https://github.com/apache/geode/pull/525#discussion_r118150229 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java --- @@ -485,9 +485,14 @@ public Result

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Hello Darrel, I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork. I'll clo

[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #534: GEODE-2962: Added null check to log message

2017-05-24 Thread AkihiroKitada
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/534 GEODE-2962: Added null check to log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode.

[GitHub] geode issue #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 Create by mistake. Close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode pull request #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 I create this PR by mistake. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] geode pull request #535: GEODE-2986: Remove redundant log message

2017-05-24 Thread AkihiroKitada
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/535 GEODE-2986: Remove redundant log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode.

[GitHub] geode issue #535: GEODE-2986: Remove redundant log message

2017-07-23 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/535 Hello folks, In terms of proceeding this PR, what should do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #535: GEODE-2986: Remove redundant log message

2017-07-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/535 Hello folks, Thank you for paying your attention to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your