Big thank you to Evaristo for presenting on query resource management today! It
was very intersting to learn about the problems you and your team had run into
around query resource consumption, how you worked around them and how we might
improve that area of Apache Geode further in the future.
As of July, 2021, Geode's build system no longer executes test worker processes
in separate Docker containers.
This increases the risk of port collisions between tests. Each test worker JVM
and each Java process started by a test executes directly in the environment
provided by the host machine
Hey all,
We're introducing a mess to the codebase. It's a small problem, but several
small problems become a big problem and one of my missions is to clean up
and improve the codebase.
I recently started seeing lots of pull requests with usage of @TestOnly.
Sometimes it's used instead of @Visible
As everyone thinks about how we want to use these annotations, please keep
this in mind that both *@VisibleForTesting* and *@TestOnly* can be used on
Types (Class/Interface/Enum), Constructors, Methods and Fields. (not just
Methods)
On Thu, Nov 4, 2021 at 3:09 PM Kirk Lund wrote:
> Hey all,
>
>
Dale, Thanks for doing this work and especially for adding these guidelines
to the Wiki!
On Thu, Nov 4, 2021 at 1:08 PM Dale Emery wrote:
> As of July, 2021, Geode's build system no longer executes test worker
> processes in separate Docker containers.
>
> This increases the risk of port collisi
Hello Geode Developers,
Next week, Wednesday, 10 November 2021, we are planning to upgrade the Apache
Geode Concourse deployment from version 6.7.4 to 7.6.0. We will also be moving
the backend for Concourse from Bosh to k8s. We will deploy all production
pipelines (Apache repo, develop and supp
My opinion is that @VisibleForTesting is a code smell and either indicates that
there is refactoring needed or there are tests that are unnecessary. If there
is functionality in a private method that needs to be tested independently,
then that code should be extracted and placed in a separate cl
It would be really great if there were java tooling to actually compile
separate production binaries and test binaries based on annotations like this,
rather than having to ship methods that were only exposed for testing.
If such a preprocessor does exist, @TestOnly provides a stronger, unambigu
I agree with Eric. Maybe rather than standardizing on one, we should stop
adding anymore @VisibleForTesting or @TestOnly to the codebase. Possibly
deprecate @VisibleForTesting.
> On Nov 4, 2021, at 3:30 PM, Eric Zoerner wrote:
>
> My opinion is that @VisibleForTesting is a code smell and eithe
My understanding is @VisibileForTesting methods are used by the products, while
@TestOnly methods are used only by the tests.
In practice, I don’t like to add @TestOnly methods (although I like to mark
those methods with this annotation if I found out a method is only used for
testing for bette
Another +1 to Eric's point. What are others seeing as valid use cases for those
annotations?
From: Patrick Johnson
Sent: Thursday, November 4, 2021 15:55
To: dev@geode.apache.org
Subject: Re: @TestOnly or @VisibleForTesting
I agree with Eric. Maybe rather than s
11 matches
Mail list logo
