Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list

2021-03-12 Thread Donal Evans
After some investigation, it appears that a degradation has been introduced that causes the P2pPartitionedPutLongBenchmark to fail at an increased rate. Efforts are underway to narrow down the cause to a single commit, but the degradation was definitely introduced in 1.14, so I believe this shou

Re: Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list

2021-03-12 Thread Nabarun Nag
+1 From: Donal Evans Sent: Friday, March 12, 2021 11:19 AM To: dev@geode.apache.org Subject: Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list After some investigation, it appears that a degradation has be

[Proposal] Backport GEODE-9022 to Apache Geode 1.14

2021-03-12 Thread Raymond Ingles
Hello – Putting forward the proposal to backport GEODE-9022 (Redis INFO command support) to support/1.14 branch, What does GEODE-9022 do? * It adds unit/integration/dunit tests for the Redis INFO command * It moves the INFO command to the ‘Supported’ category

[Proposal] Backport GEODE-9009 - Support for Redis DECRBY command

2021-03-12 Thread Raymond Ingles
Hello – Putting forward the proposal to backport GEODE-9009 (Redis DECRBY command support) to support/1.14 branch, What does GEODE-9009 do? * It adds unit/integration/dunit tests for the Redis DECRBY command * It moves the DECRBY command to the ‘Supported’ categ

Re: Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list

2021-03-12 Thread Owen Nichols
Thanks for spotting this and looking into it, let's keep it on the blocker list and get a better understanding. On 3/12/21, 11:21 AM, "Nabarun Nag" wrote: +1 From: Donal Evans Sent: Friday, March 12, 2021 11:19 AM To: dev@geode.apache.org

Re: [Proposal] Backport GEODE-9022 to Apache Geode 1.14

2021-03-12 Thread Owen Nichols
Sounds like this is worth tracking as a blocker, thanks for making a clear and compelling case. On 3/12/21, 12:08 PM, "Raymond Ingles" wrote: Hello – Putting forward the proposal to backport GEODE-9022 (Redis INFO command support) to support/1.14 branch, What does GEODE

Re: [Proposal] Backport GEODE-9009 - Support for Redis DECRBY command

2021-03-12 Thread Owen Nichols
Sounds like this is worth tracking as a blocker, thanks for explaining the consequence of not including this. On 3/12/21, 12:08 PM, "Raymond Ingles" wrote: Hello – Putting forward the proposal to backport GEODE-9009 (Redis DECRBY command support) to support/1.14 branch,

Re: Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list

2021-03-12 Thread Jacob Barrett
That 4.6% degradation is within our thresholds so it is possible this came in well before the first time it was detected. Some context on the benchmark for those unfamiliar: P2pPartitionedPutLongBenchmark performs a fire hose of puts with Long key and Long value directly from each of the two se

Re: Proposal: Add GEODE-8950 (performance degradation in P2pPartitionedPutLongBenchmark) to 1.14 blockers list

2021-03-12 Thread Donal Evans
That 4.6% degradation is within our thresholds so it is possible this came in well before the first time it was detected. After doing some bisecting, I've found that Geode SHA 986733ec (committed on Nov 20th 2020) shows an average degradation of ~1% compared to the 1.13 baseline, whereas e26d759

[PROPOSAL]: Backport redis-compatibility changes to 1.14 - GEODE-9021 and GEODE-9023

2021-03-12 Thread Jens Deppe
These changes relate to Redis-compatibility which will be enabled and non-experimental in 1.14 GEODE-9021: Avoid unnecessary buffer creation in redis Coder * Provides performance improvements in terms of CPU and memory usage GEODE-9023: Add sharding support to redis region * This chang

Re: [PROPOSAL]: Backport redis-compatibility changes to 1.14 - GEODE-9021 and GEODE-9023

2021-03-12 Thread Darrel Schneider
+1 From: Jens Deppe Sent: Friday, March 12, 2021 2:13 PM To: dev@geode.apache.org Subject: [PROPOSAL]: Backport redis-compatibility changes to 1.14 - GEODE-9021 and GEODE-9023 These changes relate to Redis-compatibility which will be enabled and non-experimenta

CODEOWNERS vs CODEWATCHERS

2021-03-12 Thread Owen Nichols
The Geode community has certainly become closer now that CODEOWNERS automatically adds a lot of people to the reviewer list for new PRs, but you may still feel like you’re missing out on PRs outside your area of expertise. If you are a committer and there are additional code areas you’d like to

Re: [PROPOSAL]: Backport redis-compatibility changes to 1.14 - GEODE-9021 and GEODE-9023

2021-03-12 Thread Owen Nichols
Thanks for getting these on the list! Added to blocker board. On 3/12/21, 2:31 PM, "Darrel Schneider" wrote: +1 From: Jens Deppe Sent: Friday, March 12, 2021 2:13 PM To: dev@geode.apache.org Subject: [PROPOSAL]: Backport redis-compatib

Re: [DISCUSS] Cutting a Geode 1.14.0 release branch

2021-03-12 Thread Owen Nichols
Weeks since support/1.14 cut: 4 Blockers backported this week: 9 Blockers we are still waiting on: 9 If there's anything else we should be waiting on, please make a proposal to add it to the blocker board sooner rather than later (even if you're still investigating...fix doesn't have to be fu

[Proposal] Backport GEODE-9029 - Initial support for Redis SLOWLOG command

2021-03-12 Thread Raymond Ingles
Hello – Putting forward the proposal to backport GEODE-9029 (Redis SLOWLOG command support) to support/1.14 branch, What does GEODE-9029 do? * It adds unit/integration/dunit tests for the Redis SLOWLOG command * It moves the SLOWLOG command to the ‘Supported’ category

Re: [Proposal] Backport GEODE-9029 - Initial support for Redis SLOWLOG command

2021-03-12 Thread Darrel Schneider
+1 From: Raymond Ingles Sent: Friday, March 12, 2021 4:29 PM To: dev@geode.apache.org Subject: [Proposal] Backport GEODE-9029 - Initial support for Redis SLOWLOG command Hello – Putting forward the proposal to backport GEODE-9029 (Redis SLOWLOG command suppor