Re: errors from logging code in unit tests

2021-02-25 Thread Bruce Schuchardt
Every "distributed" unit test I've run lately has had it. I just tried ClusterCommunicationsDUnitTest. createEntryAndVerifyUpdate(), for instance, and see these ERRORs in the output. For some reason the test runner ignores these messages and the tests pass. On 2/24/21, 4:07 PM, "Udo Kohlmeye

Concourse access

2021-02-25 Thread Mario Salazar de Torres
Hi everyone, I am trying to access one of the jobs for the geode-native concourse pipeline (I.E: https://concourse.apachegeode-ci.info/builds/7105), but the only thing I can see is a loading message. Do I need any read permissions? If that's the case, this is my GitHub username is 'gaussianrecurr

Geode Native Tooling

2021-02-25 Thread Jacob Barrett
Hey Geode Native devs, You may have noticed this new CI that looks a lot like the Java CI. PRs will now be executed against this CI and several platforms. All unit and integration tests are executed on all the platforms as well. It also takes over the tasks of the old Travis CI of validating yo

Re: Geode Native Tooling

2021-02-25 Thread Mario Salazar de Torres
Hi Jacob, No words to describe what a huge effort you put into this. I think it's really going to ease verification work for everyone in the future. However, today I was running one PR on Concourse and I noticed that Windows 2019 job was failing. Could it be that there are some details to polish

Re: code-owners seems to have some problems

2021-02-25 Thread Mark Hanson
Hi Owen, Is there a way to ensure that draft mode PRs aren't requesting reviews from code owners? Thanks, Mark On 2/19/21, 11:44 AM, "Owen Nichols" wrote: GitHub provides some tools to answer this kind of question. Step 1: Under the PR's "Files Changed" tab, click File Filter > Your

Re: code-owners seems to have some problems

2021-02-25 Thread Owen Nichols
GitHub does not add reviewers from CODEOWNERS to PRs created as draft PRs (until you mark it not-draft by clicking Ready For Review). However if you subsequently change it back to a draft, GitHub will not remove any reviewers. On 2/25/21, 10:28 AM, "Mark Hanson" wrote: Hi Owen, Is t

Re: code-owners seems to have some problems

2021-02-25 Thread Mark Hanson
Hi Owen, Two more questions. Is it the case that only one of the code owners for that area has to review the PR? Also, is there a way to tell that a code owner has reviewed an area, so you don't have to as one of the other code owners? Thanks, Mark On 2/25/21, 10:31 AM, "Owen Nichols" wrote

Re: Geode Native Tooling

2021-02-25 Thread Ernie Burghardt
Aka different versions of clang-format are not compatible in a sense... also, watch out for non-standard clang-format versions that may come with certain IDEs... On 2/25/21, 9:04 AM, "Jacob Barrett" wrote: Hey Geode Native devs, You may have noticed this new CI that looks a lot like

Re: Geode Native Tooling

2021-02-25 Thread Jacob Barrett
Running the legacy tests on windows is still flaky. Windows! > On Feb 25, 2021, at 9:46 AM, Mario Salazar de Torres > wrote: > > Hi Jacob, > > No words to describe what a huge effort you put into this. I think it's > really going to ease verification work for everyone in the future. > However

RE: Geode Native Tooling

2021-02-25 Thread Alberto Bustamante Reyes
Very good news for the native client. Thanks for the improvement Jacob! BR/ Alberto B. De: Jacob Barrett Enviado: jueves, 25 de febrero de 2021 20:49 Para: dev@geode.apache.org Asunto: Re: Geode Native Tooling Running the legacy tests on windows is still flaky.

Re: Concourse access

2021-02-25 Thread Jacob Barrett
I made the pipelines public. If you want more access than that let us know. Before that though can you give me a sense for the usability of the public access on the pipelines? Thanks, Jake > On Feb 25, 2021, at 8:31 AM, Mario Salazar de Torres > wrote: > > Hi everyone, > I am trying to acce

Re: code-owners seems to have some problems

2021-02-25 Thread Robert Houghton
Hi Mark, Yes, each area of ownership only needs one review-by-owner. Your following question, I do not understand, but I'll try: Any PR that needs review, will have text in the "reviewers needed and status-required" area, that states who is still needed to review. However, there is not a direct

Re: Concourse access

2021-02-25 Thread Mario Salazar de Torres
Hi Jacob, In my case, I can see now both geode-native-develop and geode-native-develop-pr set of pipelines, but when I try to see any execution of any of its pipelines I am stuck at the loading message. Interestingly I've noticed that one of the underlying requests sent (https://concourse.apac

Re: code-owners seems to have some problems

2021-02-25 Thread Mark Hanson
Hi Robert, Thanks! You answered the question the way I intended. Thanks, Mark On 2/25/21, 12:57 PM, "Robert Houghton" wrote: Hi Mark, Yes, each area of ownership only needs one review-by-owner. Your following question, I do not understand, but I'll try: Any PR that needs review,

Re: [VOTE] Apache Geode 1.12.1.RC4

2021-02-25 Thread Owen Nichols
It's past the announced deadline and we have enough votes to close the vote. Voting status == +1: 4 binding votes * Dick Cavender (PMC member) * John Blum (PMC member) * Dave Barnes (PMC member) * Robert Houghton (PMC member) * Donal Evans +0: zero votes -0: zero votes -1: zero votes

Passed: apache/geode-examples#527 (rel/v1.12.1 - 75ead25)

2021-02-25 Thread Travis CI
Build Update for apache/geode-examples - Build: #527 Status: Passed Duration: 22 mins and 59 secs Commit: 75ead25 (rel/v1.12.1) Author: Owen Nichols Message: Revert "temporarily point to staging repo for CI purposes" View the changeset: https://github.com/apac

Passed: apache/geode-native#3060 (rel/v1.12.1 - ba8fd9b)

2021-02-25 Thread Travis CI
Build Update for apache/geode-native - Build: #3060 Status: Passed Duration: 1 hr, 17 mins, and 34 secs Commit: ba8fd9b (rel/v1.12.1) Author: Owen Nichols Message: Bumping copyright year to 2021 View the changeset: https://github.com/apache/geode-native/compar

Broken: apache/geode-native#3062 (support/1.12 - 3e855a8)

2021-02-25 Thread Travis CI
Build Update for apache/geode-native - Build: #3062 Status: Broken Duration: 3 mins and 19 secs Commit: 3e855a8 (support/1.12) Author: Owen Nichols Message: Bumping Geode version to 1.12.1 for CI View the changeset: https://github.com/apache/geode-native/comp