[DISCUSS] client/server communications and versioning

2021-02-23 Thread Bruce Schuchardt
I’m considering a change in client/server communications that I would like feedback on. We haven’t changed on-wire client/server communications since v1.8 yet we tie these communications to the current version. The support/1.14 branch identifies clients as needing v1.14 for serialization/deser

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Alberto Gomez
+1 This proposal makes a lot of sense. Besides, I recently sent a proposal to allow clients to communicate with servers in an older version in case the compatibility was not broken in the new version of the client ([1]). With your proposal, the aim of that RFC could also be achieved. Following

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Owen Nichols
Sounds reasonable. We increment the serialization version every minor release "just in case" anything has changed in the server-to-server protocol, but client-to-server should change a lot less frequently, as you pointed out. Now that Geode is maintaining support branches with longer life, rath

Re: [DISCUSS] - RFC make key and trust stores reload automatically upon change

2021-02-23 Thread Aaron Lindsey
It doesn't look like this RFC has received any comments after being open for more than 2 weeks. As a reminder, if anyone has feedback on our approach please reach out as we are planning to start implementing the solution described. Thanks, Aaron From: Jo

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Dan Smith
Ha, I was thinking of suggesting this when I saw Alberto's earlier proposal. This does seem like a good idea to only bump the client version when the protocol actually changes. One concern is that it might not be obvious that changing a DataSerializableFixedId will change the client protocol. S

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Anilkumar Gingade
Bruce, >> To solve that problem we currently have to issue a new 1.13 release that >> knows about v1.12.1 and users have to roll their servers to the new v1.13.1. Even if we introduce the client protocol version, the users still need to upgrade to server version, that understands the protocol rig

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Bruce Schuchardt
I was worrying about DSFID changes, too, but I think we'll know if we need the updated data in the client. What might be surprising to people is if they make a change and don't see it getting to the client because it's using an old version. If I add a field to a DSFID and update toData to incl

Re: [DISCUSS] client/server communications and versioning

2021-02-23 Thread Bruce Schuchardt
Yes, if we change the client/server protocol version in a patch release we'll have to update newer releases to know about it. I don't recall that happening much over the years, though. We used to guarantee there would be no on-wire incompatibilities for clients in patch releases, didn't we? T