Re: PR pending review

2020-12-18 Thread Mark Hanson
Hi Ashish, Most of the team are on holiday at this point, so it is going to take a while before they will respond. I will review your PRs today, though I am not a subject matter expert on either of these areas. Thanks, Mark On 12/17/20, 6:40 AM, "aashish choudhary" wrote: Hi, Can

Canceled: apache/geode-native#2894 (develop - 4f504e4)

2020-12-18 Thread Travis CI
Build Update for apache/geode-native - Build: #2894 Status: Canceled Duration: ? Commit: 4f504e4 (develop) Author: Mario Salazar de Torres Message: GEODE-8756: Fix CacheableString::objectSize (#703) - objectSize was not taking into account null-terminator ch

Canceled: apache/geode-native#2895 (develop - f632e30)

2020-12-18 Thread Travis CI
Build Update for apache/geode-native - Build: #2895 Status: Canceled Duration: ? Commit: f632e30 (develop) Author: Blake Bender Message: Revert "GEODE-8702: Add StringPrefixPartitionResolver (#692)" - This breaks the build on RHEL7, so reverting and reopening t

Canceled: apache/geode-native#2896 (develop - 7d334db)

2020-12-18 Thread Travis CI
Build Update for apache/geode-native - Build: #2896 Status: Canceled Duration: ? Commit: 7d334db (develop) Author: Blake Bender Message: Revert "Revert "GEODE-8702: Add StringPrefixPartitionResolver (#692)"" This reverts commit f632e307a45310f4f18c9ef7e8d6c880

Re: [DISCUSS] Geode 1.14

2020-12-18 Thread Owen Nichols
To summarize this thread so far: @Robert and @Jens seem to favor “cut then stabilize” @Alexander and @John seem to favor “stabilize then cut” No one seems to favor “cut on a predetermined date” (at least for 1.14) @John also made a creative suggestion that maybe 1.14 doesn’t have to be cut from l

Passed: apache/geode-native#2897 (develop - 0681c33)

2020-12-18 Thread Travis CI
Build Update for apache/geode-native - Build: #2897 Status: Passed Duration: 1 hr, 21 mins, and 45 secs Commit: 0681c33 (develop) Author: Blake Bender Message: Revert "GEODE-8756: Fix CacheableString::objectSize (#703)" This reverts commit 4f504e4c4b229d883002

Re: [DISCUSS] Geode 1.14

2020-12-18 Thread Mark Hanson
I support the cut on a predetermined date. But I will be ok with the Stabilize first approach, because I think that having a stable build is a prerequisite for any time based model. But like all things, this is a smell that we have to do this... The other thing is that specifying a date or a win