+1
We should also get rid of the old jump tables in CommandInitializer
On 12/8/20, 2:38 PM, "Jacob Barrett" wrote:
We all do lots of cleanup as we go through areas of the source, like
optimizing lambda expressions, renaming variables with more meaningful names
and deleting commented out c
> On Dec 9, 2020, at 8:09 AM, Bruce Schuchardt wrote:
>
> We should also get rid of the old jump tables in CommandInitializer
Would it make sense to do that in the same PR that tackles setting the min
client version in the handshake or should that be a separate task?
-Jake
+1 to rejecting clients (and WAN sites) with versions less than
KnownVersion.GFE_82, and obsolete compatibility code.
-Dan
From: Jacob Barrett
Sent: Wednesday, December 9, 2020 9:35 AM
To: dev@geode.apache.org
Subject: Re: [Proposal] - Cleanup Protocol Version C
I will go ahead and withdraw my objection to this change. Based on some side
conversations, at least at VMWare it sounds like we don't have customers that
are not setting this flag. So the scenario I'm worried about where a customer
upgrades their production cluster and has it crash due to this
> Feedback appreciated by 12/18 before a formal acceptance vote is requested.
BTW, I don't think a vote is necessary. If you don't get objections by 12/18 I
think you can just move forward.
-Dan
From: Dan Smith
Sent: Wednesday, December 9, 2020 11:16 AM
To: dev@
I agree with Dan, here, along with the consensus that false is the better
default (in most cases).
So, I simply want to re-iterate the importance of "documentation" in whatever
direction we decide. There are, without a doubt, both pros and cons to each
configuration arrangement (true of false)
Thank you to everyone who participated in this discussion.
After a quick tally of responses, it looks like there are 6 people in favour of
the change happening right now and 3 who are in favour but would prefer it to
wait for a major version change. While this isn't a strong consensus, I do
thi
Build Update for apache/geode-native
-
Build: #2841
Status: Passed
Duration: 1 hr, 23 mins, and 21 secs
Commit: 03f6031 (support/1.14)
Author: Michael Martell
Message: GEODE-8754: Fix uninitialized variable in
DataInput::ReadInternalObject (#704)
* Initialize
+1 Good suggestion.
I have no idea what the scope of the cleanup looks like, but it seems like an
excellent entry-point for newcomers to the codebase to get their hands dirty.
I know this is a weird request, but I'd like to ask committers not to jump on
this, but allow some time for non-committ
