Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-12-07 Thread Robert Houghton
I haven’t seen any negative responses, and a big THANK YOU to @onichols for making the first PR to self-volunteer into ownership of some code. Lets give people another week to nominate, or self-nominate, as PRs against [feature/introduce-codeowners], and plan to merge this feature into develop o

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-12-07 Thread Jens Deppe
Should we just be adding to Owen's PR? If everyone creates their own PR we'll probably end up with a bunch of merge conflicts. --Jens On 12/7/20, 10:07 AM, "Robert Houghton" wrote: I haven’t seen any negative responses, and a big THANK YOU to @onichols for making the first PR to self-vo

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-12-07 Thread Robert Houghton
To be honest, I hadn’t thought of the mess that might make. I guess, we can either make changes directly to the feature branch, which will eventually have a pull-request back to [develop], or we can modify Owen’s existing PR. At the end of the day, it all has to go through the normal PR process

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-12-07 Thread Owen Nichols
Let’s keep this simple. If you’re nominating yourself, just commit to the branch directly. If you wish to nominate someone else, make a PR and tag them as a reviewer. Robert, do you want to give this part of the process a week or so, and on Dec 14 take what we’ve got on the branch and create