Re: PR process and etiquette

2020-10-29 Thread Bruce Schuchardt
I totally agree that folks should use Draft mode for things that aren't ready for review. Beyond that it's easy enough to look at a PR and see if it's in Draft state or hasn't passed checks before putting in an effort to review the code. However, going into the code of a Draft PR or one that h

Re: PR process and etiquette

2020-10-29 Thread Alberto Gomez
Hi there, Here come my 2 cents. @Udo Kohlmeyer, thanks for your proposals to make this community better, and also for your willingness to get feedback from people who are new to the community. In my experience, one of the tricky parts working in the community is getting

Re: PR process and etiquette

2020-10-29 Thread Donal Evans
As a (relatively) new committer, one of the more difficult aspects of the PR process is knowing who to tag as a reviewer. The last person to touch a class may not actually have the context or depth of knowledge needed for a thorough review if, say, their changes were just refactoring or code cle

Re: PR process and etiquette

2020-10-29 Thread Sarah Abbey
Regarding knowing who to tag in a PR, because I am working on a very specific aspect of Geode, it was frustrating before I was a committer to not be able to add reviewers since I knew the handful of people that had enough context to review most of the PRs I submitted. But it is also not hard fo

Re: PR process and etiquette

2020-10-29 Thread Darrel Schneider
+1 for adding a CONTRIBUTING.MD file From: Sarah Abbey Sent: Thursday, October 29, 2020 2:07 PM To: dev@geode.apache.org Subject: Re: PR process and etiquette Regarding knowing who to tag in a PR, because I am working on a very specific aspect of Geode, it was f