Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Joris Melchior
I lean towards forks as well. I understand Naba's concerns but for most of the work we do, forks are a straightforward way to work on contributions to Geode. It's easy to give people rights on your fork if you work with multiple contributors. Joris From: Ernie B

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Bruce Schuchardt
Jake, you make some good points that I hadn't considered before. On 6/2/20, 3:42 PM, "Jacob Barrett" wrote: I know this has been brought up multiple times without resolution. I want us resolve to ban the use of Geode repository for work in progress, feature branches, or any other branches

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Aaron Lindsey
I'm on board with using forks — the exception being Naba's use case for long running feature branches where developers actually want to open a PR into the branch From: Bruce Schuchardt Sent: Wednesday, June 3, 2020 8:23 AM To: dev@geode.apache.org Subjec

RE: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Nabarun Nag
Thank you Aaron. We will continue using feature branch in ASF repo for development of PR clear work. Yes, we can manage access to personal/non-ASF hosted forks but I do not have the list of people to set that up. This is automatic default when we create in ASF repositories. Also, I am vehemen

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Mark Hanson
There is also one other positive of having it in the ASF repo which is visibility to other people committing breaking changes. That might help with coordination. Thanks, Mark On 6/3/20, 10:51 AM, "Nabarun Nag" wrote: Thank you Aaron. We will continue using feature branch in ASF rep

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Jianxia Chen
For features that need collaboration among multiple contributors/committers and extended amount of time, using a feature branch in ASF repo is more convenient, compared to using a fork. Other than that, using a fork is preferable. Thanks, Jianxia On Wed, Jun 3, 2020 at 11:06 AM Mark Hanson wrote

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Xiaojian Zhou
We have discussed that when in Common team. The current solution worked perfectly. One person will merge the develop into feature/GEODE-7665 (which conceptually can be anyone. I did 2 times) every week. Now Naba is taking the responsibility to do the weekly merge. He did great! Fork will caus

Broken: apache/geode-native#2456 (develop - 1400f50)

2020-06-03 Thread Travis CI
Build Update for apache/geode-native - Build: #2456 Status: Broken Duration: 1 hr, 18 mins, and 45 secs Commit: 1400f50 (develop) Author: Michael Martell Message: GEODE-8214: Add new ServerDisconnect test (#610) View the changeset: https://github.com/apache/g

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Dave Barnes
Suppose I want to commit to another contributor's fork. How can they grant me permission to do so? (This is a common predicament for me when I'm reviewing doc PRs.) On Wed, Jun 3, 2020 at 2:04 PM Xiaojian Zhou wrote: > We have discussed that when in Common team. The current solution worked > pe

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Jianxia Chen
The contributor has to add you as a collaborator of the contributor’s fork. On Wed, Jun 3, 2020 at 5:05 PM Dave Barnes wrote: > Suppose I want to commit to another contributor's fork. How can they grant > me permission to do so? (This is a common predicament for me when I'm > reviewing doc PRs.)