Re: [VOTE] Apache Geode 1.9.2.RC1

+1, Downloaded and built from source, created two clusters with multiple members and verified WAN replication (along with some gateway related commands) work properly. Best regards. On Mon, Oct 21, 2019 at 8:04 PM Udo Kohlmeyer wrote: > +1, > > Checked that WAR's are generated for geode-web an

Re: [DISCUSS] Blocking merge button in PR

I would advise against including "StressNewTestOpenJDK11". I have had trouble with this one when doing something as simple as a method rename. Because that method was called from an old test, StressNewTest ran that old test many times. Not all of our current tests can handle being rerun many times.

Re: [DISCUSS] Blocking merge button in PR

Darrel, In my opinion, Stress new tests is one of the important test suites that needs to be activated. This is only test suite that can prevent the influx of flaky tests. We have seen a heavy rise in the number of tickets being created recently. Old tests can be avoided from running in the suite

access to concourse.apachegeode-ci.info

May I have access to concourse.apachegeode-ci.info, so that I can see details of of my jobs, and re-trigger failed PR jobs? Thanks. Karen

Re: [DISCUSS] log4j errors/warnings

I'm ok with adding log4j-core to the testRuntime for all unit test targets to prevent the ERROR message. Any other input? On Fri, Oct 18, 2019 at 3:10 PM John Blum wrote: > Be careful to only add logging dependencies as testRuntime dependencies. > Do not add any logger implementation/provider (e

Re: [DISCUSS] log4j errors/warnings

I hit this problem in PR. I am just curious why it did not happen before? On Tue, Oct 22, 2019 at 9:44 AM Kirk Lund wrote: > I'm ok with adding log4j-core to the testRuntime for all unit test targets > to prevent the ERROR message. Any other input? > > On Fri, Oct 18, 2019 at 3:10 PM John Blum

DistributedTestOpenJDK8 timing out

DistributedTestOpenJDK8 is timing out here-and-there in CI and precheckin runs. When was the last time we increased the timeout for this job? Anyone want to increase it now?

Re: [DISCUSS] Blocking merge button in PR

This discussion has revolved around the assumption that all changes go through the PR process. If you’re a committer, nothing forces you to create a PR — you can also just commit directly to develop. PRs are commonly used when the committer wants feedback (from the PR checks and/or from the co

Re: [DISCUSS] Blocking merge button in PR

Owen , Or any other developers *please do not push directly to Apache Geode develop code base without creating a pull request, asking for reviews and testing the code*. To rephrase, what you are saying is that now developers, in order to avoid reviews and testing their code, will now push directly

Re: [DISCUSS] Blocking merge button in PR

I also have my doubts about StressNewTest testing being required to pass.  Maybe if they just tested new tests instead of anything your changes happened to touch it would be easier to pass this check. Also, the StressNewTest check runs the selected tests in parallel and apparently in the same

Re: [DISCUSS] log4j errors/warnings

There are other ways of controlling the Log4j2 Status Logger other than adding test dependencies. For instance, you can: 1. Set the JVM System property org.apache.logging.log4j.simplelog.StatusLogger.level to "OFF". 2. Theoretically, when Lo4j2 finds a log4j2 or log4j2-test Properties, YAML, JS

Re: [DISCUSS] log4j errors/warnings

In CI, I keep hitting "> Task :geode-assembly:defaultCacheConfig 09:13:37 ERROR StatusLogger Log4j2 could not find a logging implementation. Please add log4j-core

Re: [DISCUSS] Blocking merge button in PR

To Bruce's point: I don't see stress new test as something that's supposed to be easy to pass. I do agree that it should be easy to figure out what went wrong, but the point of this task was the catch issues with tests being flaky or non-repeatable for other reasons. If we reduce the scope of this

Re: [VOTE] Apache Geode 1.9.2.RC1

+1 Downloaded, successfully built Geode and Geode-Native docs form source. On Tue, Oct 22, 2019 at 2:17 AM Ju@N wrote: > +1, > > Downloaded and built from source, created two clusters with multiple > members and verified WAN replication (along with some gateway related > commands) work properly.

Re: [VOTE] Apache Geode 1.9.2.RC1

+1 Downloaded source code, build and ran tests. Started a cluster and was able to execute basic operations. Compiled and ran examples Validated pipeline was run successfully for the SHA we are shipping On Tue, Oct 22, 2019 at 2:17 AM Ju@N wrote: > +1, > > Downloaded and built from source, creat

Re: [DISCUSS] log4j errors/warnings

Just to be clear... this does NOT cause any precheckin or CI failures. It's just noise caused by log4j-api nagging about the lack of a backend. On Tue, Oct 22, 2019 at 11:33 AM Xiaojian Zhou wrote: > In CI, I keep hitting "> Task :geode-assembly:defaultCacheConfig > > 09:13:37 < > https://concou

Re: [DISCUSS] log4j errors/warnings

Note: John's suggestions are some really good alternatives to consider instead of adding log4j-core to the unit testing classpaths. On Tue, Oct 22, 2019 at 11:31 AM John Blum wrote: > There are other ways of controlling the Log4j2 Status Logger other than > adding test dependencies. > > > For in

Re: [VOTE] Apache Geode 1.9.2.RC1

+1 On Tue, Oct 22, 2019 at 11:47 AM Dave Barnes wrote: > +1 > Downloaded, successfully built Geode and Geode-Native docs form source. > > On Tue, Oct 22, 2019 at 2:17 AM Ju@N wrote: > > > +1, > > > > Downloaded and built from source, created two clusters with multiple > > members and verified W

Reviewers for GEODE-7184: Fix failing Windows acceptance tests

Could one or two others please review and/or merge this PR? It fixes failures in Windows acceptance test jobs in the develop CI pipeline. https://github.com/apache/geode/pull/4192 - Aaron

Re: [VOTE] Apache Geode 1.9.2.RC1

+1 Built Spring Data for Apache Geode on 1.9.2 with success. On Tue, Oct 22, 2019 at 1:28 PM Jinmei Liao wrote: > +1 > > On Tue, Oct 22, 2019 at 11:47 AM Dave Barnes wrote: > > > +1 > > Downloaded, successfully built Geode and Geode-Native docs form source. > > > > On Tue, Oct 22, 2019 at 2:17

Re: [DISCUSS] Blocking merge button in PR

@owen, whilst you are technically correct, THIS is not the process that we as a Geode committer community have agreed upon. The commit process within GEODE is to raise a PR. Simple... --Udo On 10/22/19 9:53 AM, Owen Nichols wrote: This discussion has revolved around the assumption that all c

[REQUEST] Squash merge please

Hi Geode Committers, A kind request for using squash commit instead of using merge. This will really help us in our bisect operations when a regression/flakiness in the product is introduced. We can automate and go through fewer commits faster, avoiding commits like "spotless fix" and "re-trigger