Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Alberto Gomez
Hi, I would not back out the LGTM changes added in the PR as they are necessary. - Alberto On 31/7/19 23:46, Jacob Barrett wrote: > I would say for this PR, back out the LGTM changes and just move forward > ignoring the LGTM results.

Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Blake Bender
I agree with Jake on this one. From a bookkeeping perspective, what I'd like to see in the history is a single commit that fixes all the LGTM issues, and your fix for this bug in a separate commit. I have a copy of your .yml changes on my "fix LGTM" branch already, please back that change out and

Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Alberto Gomez
Having put it this way, I agree with you guys ;-) Thanks, -Alberto On 1/8/19 18:02, Blake Bender wrote: > I agree with Jake on this one. From a bookkeeping perspective, what I'd > like to see in the history is a single commit that fixes all the LGTM > issues, and your fix for this bug in a sepa

Server recovery severely degrades client read traffic

2019-08-01 Thread Mario Ivanac
Hi, we are observing severe throttling from the cluster when getting data from a partitioned region (no SH nor TX) while server hosting one of the redundant buckets is recovering (see ticket https://issues.apache.org/jira/browse/GEODE-7039). Currently, Get operations that have not landed on a