I think it would be a mistake to have just the main pipeline catch
analyze-serializable failures. It is easy to accidentally cause these
failures so I think we want them caught early. They are also not flaky so
if broken then they will consistently fail. I think this would cause
someone extra work
The PR pipeline should be a timely test, but also sane and helpful. Maybe
making the JDK8 Unit tests (but not the integration, etc) part of PR is a
good compromise in that sense.
On Sun, May 19, 2019 at 2:20 AM Owen Nichols wrote:
> Correct, analyze-serializables test is currently skipped under
I that the serialization test was only an issue when compiled with JDK11? We
don’t compile with JDK11, we compile with JDK8 and run under JDK11.
> On May 20, 2019, at 8:50 AM, Robert Houghton wrote:
>
> The PR pipeline should be a timely test, but also sane and helpful. Maybe
> making the JDK8
I'd like to discuss the proposal to add Peter Tran as a new Geode
committer and PMC member. Peter has been working with Manageability
team for a while now and has contributed to the team immensely. Before
that he was a key contributor to PCC team.
Please cast your vote. Voting ends one week from
Jinmei,
Discussions related to committers and PMC members should be held on the
private@geode mailing list not the dev@ list.
Thanks,
Anthony
> On May 20, 2019, at 11:15 AM, Jinmei Liao wrote:
>
> I'd like to discuss the proposal to add Peter Tran as a new Geode
> committer and PMC member.
oops, please disregard this message then. Thanks!
On Mon, May 20, 2019 at 11:23 AM Anthony Baker wrote:
> Jinmei,
>
> Discussions related to committers and PMC members should be held on the
> private@geode mailing list not the dev@ list.
>
>
> Thanks,
> Anthony
>
>
> > On May 20, 2019, at 11:15
This has the heading [DISCUSS] instead of [VOTE]
I'm +1 anyway.
On Mon, May 20, 2019 at 2:15 PM Jinmei Liao wrote:
> I'd like to discuss the proposal to add Peter Tran as a new Geode
> committer and PMC member. Peter has been working with Manageability
> team for a while now and has contributed
+1
On Mon, May 20, 2019 at 11:50 AM Mike Stolz wrote:
> This has the heading [DISCUSS] instead of [VOTE]
>
> I'm +1 anyway.
>
> On Mon, May 20, 2019 at 2:15 PM Jinmei Liao wrote:
>
> > I'd like to discuss the proposal to add Peter Tran as a new Geode
> > committer and PMC member. Peter has been
Folks, this thread is dead. Please stop voting here!
>From Anthony:
Discussions related to committers and PMC members should be held on the
private@geode mailing list not the dev@ list.
On Mon, May 20, 2019 at 1:43 PM Xiaojian Zhou wrote:
> +1
>
> On Mon, May 20, 2019 at 11:50 AM Mike Stolz
@rhoughton - sounds reasonable. JDK8 Unit tests are added back to PR checks
now.
@jbarrett - good point, no need to skip analyze-serializables test when
compiled with JDK8. Jinmei has a PR to un-skip:
https://github.com/apache/geode/pull/3607
@dschneider - do you still want to bring back all
10 matches
Mail list logo
