Re: Geode 1.9 Release Manager

2019-02-19 Thread Bruce Schuchardt
The fix for Geode-6369 has been pushed to develop.  This needs to go in the 1.9 release as it fixes some serious issues in auto-reconnect including a distributed deadlock. On 2/15/19 2:15 PM, Sai Boorlagadda wrote: There are about 8[1] issues in JIRA that are in open/in-progress/re-opened stat

Bug Numbers and Trac Numbers in comments

2019-02-19 Thread Michael Oleske
Hey Geode Dev Friends! I was reviewing a PR (this one https://github.com/apache/geode/pull/3197) and made a note that maybe we should remove comments that make references to bug and trac numbers that people cannot reach (like me for one). Kirk mentioned that some people (like him) have access to

Release branch for Apache Geode 1.9.0 has been cut

2019-02-19 Thread Sai Boorlagadda
Hello Everyone, As discussed in my earlier email I have created a new release branch for Apache Geode 1.9.0 - "release/1.9" Please do review and raise any concern with the release branch. If no concerns are raised, we will start with the voting for the release candidate soon. Regards Sai

Re: Geode 1.9 Release Manager

2019-02-19 Thread Sai Boorlagadda
Thanks Bruce. I will chery-pick this commit onto the new release branch. On Tue, Feb 19, 2019 at 1:06 PM Bruce Schuchardt wrote: > The fix for Geode-6369 has been pushed to develop. This needs to go in > the 1.9 release as it fixes some serious issues in auto-reconnect > including a distributed

Release pipeline for 1.9.0

2019-02-19 Thread Sai Boorlagadda
Hello Geode Dev Community, As we have created a release branch for Apache Geode 1.9.0 - "release/1.9.0" please create a CI pipeline for running tests on this branch. Regards Sai

Re: Release branch for Apache Geode 1.9.0 has been cut

2019-02-19 Thread Sai Boorlagadda
My earlier release branch has created as 'release/1.9' without the patch number in semver. So I have re-created a new release branch 'release/1.9.0'. I will go ahead delete the unwanted branch 'release/1.9' Sai On Tue, Feb 19, 2019 at 2:17 PM Sai Boorlagadda wrote: > Hello Everyone, > > As disc

Regarding variable name 1.10.0 ordinal?

2019-02-19 Thread Sai Boorlagadda
I am in process of adding a new ordinal for 1.10.0 and see that currently the variables are named as GEODE_XYZ for a release x.y.x (eg, private static final byte GEODE_1100_ORDINAL = 105;) Question is are there any side effects for naming it as GEODE_1100_ORDINAL for 1.10.0? Not sure if there is a

Re: Release pipeline for 1.9.0

2019-02-19 Thread Sai Boorlagadda
I am on it. On Tue, Feb 19, 2019 at 2:25 PM Sai Boorlagadda wrote: > Hello Geode Dev Community, > > As we have created a release branch for Apache Geode 1.9.0 - "release/1.9.0" > please create a CI pipeline for running tests on this branch. > > Regards > Sai > >

Re: Release branch for Apache Geode 1.9.0 has been cut

2019-02-19 Thread Jason Huynh
Correction, GEODE-6359 and GEODE-6404. On Tue, Feb 19, 2019 at 4:49 PM Jason Huynh wrote: > I still haven't gotten GEODE-6404 in... I assumed that the tickets from > the last thread were going to make it into this release? > > Also I think GEODE-6539 should be fixed, it looks like an NPE that oc

Re: Release branch for Apache Geode 1.9.0 has been cut

2019-02-19 Thread Jason Huynh
I still haven't gotten GEODE-6404 in... I assumed that the tickets from the last thread were going to make it into this release? Also I think GEODE-6539 should be fixed, it looks like an NPE that occurs when we process leave requests. On Tue, Feb 19, 2019 at 2:25 PM Sai Boorlagadda wrote: > M

Re: Bug Numbers and Trac Numbers in comments

2019-02-19 Thread Jacob Barrett
Comments that don’t provide meaningful context beyond what is already expressed in the code should be removed. A number to a system that the general public can’t access is not meaningful. Delete or replace with meaningful comment. -jake > On Feb 19, 2019, at 1:41 PM, Michael Oleske wrote: >

Re: Release branch for Apache Geode 1.9.0 has been cut

2019-02-19 Thread Sai Boorlagadda
GEODE-6404 can be cherry-picked when it is ready. The release branch is cut to avoid any risk of regression that can be introduced by new work being merged to develop. Do you mean GEODE-6369? On Tue, Feb 19, 2019 at 4:50 PM Jason Huynh wrote: > Correction, GEODE-6359 and GEODE-6404. > > On Tue,