Steps to follow after becoming a Geode committer

Hello all, My apache account is already created and everything seems to be working just fine, I've already linked my account through https://gitbox.apache.org/setup/ and I can see the option *Merge pull request* in the *GitHub* interface (disabled in the past when I didn't have commit privileges o

Re: Steps to follow after becoming a Geode committer

I believe you can go ahead. :-) The way I see it, you can merge a PR when all three are satisfied: 1) you have the privilege to merge it (the button is activated for you to push). 2) The PR is approved by a least one reviewer. 3) all checks passed. Thanks! On Mon, Sep 17, 2018, 3:48 AM Ju@N wr

Re: Steps to follow after becoming a Geode committer

Hi Juan, Great questions! I agree with what Jinmei said - go ahead and merge if you have: 1) at least one approval 2) No changes requested 3) Checks are passing The "at least one review" part is somewhat subjective, if you feel the PR is complicated and you want more reviews, feel free to ask th

Re: Need gradle help

It looks[1] like it is been renamed as 'tests', so you can try testCompile 'org.apache.logging.log4j:log4j-core:' + project.'log4j.version' + ':tests' [1] https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-core/2.11.0/ On Fri, Sep 14, 2018 at 5:17 PM Jacob Barrett wrote: > The

Updating instructions to run tests

Hi all, I recently added instructions on how to setup Geode in IntelliJ , and as part of that effort realized there is some duplication between the Wiki [1

Re: Updating instructions to run tests

I prefer creating a TESTING.md to create a clear physical grouping around the subject. I like my read me files like my source, small and well organized. > On Sep 17, 2018, at 12:00 PM, Ryan McMahon wrote: > > Hi all, > > I recently added instructions on how to setup Geode in IntelliJ >

Re: Updating instructions to run tests

+1 to separate files. It's probably worth referencing the other files in the README. On Mon, Sep 17, 2018 at 12:16 PM, Jacob Barrett wrote: > I prefer creating a TESTING.md to create a clear physical grouping around > the subject. I like my read me files like my source, small and well > organize

Running tests with a different JVM (eg Java 10)

FYI, you compile geode against one version of java and test using a different version of java with the testJVM flag. For example, this would compile with the default JDK on your machine and run tests with java 9. ./gradlew -PtestJVM=/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/ te

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1043 was SUCCESSFUL (with 2456 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #1043 was successful. --- Scheduled 2458 tests in total. https://build.spring.io/browse/SGF-NAG-1043/ -- Thi

Re: [VOTE] Apache Geode 1.7.0 RC1

*DEADLINE :* Kindly complete your vote by Wednesday, 19th September 2018. End of day PDT. Following checks completed: - checked signatures - checked sha’s - builds from source - run gfsh - start locator, server - create region - do put and get - execute OQL query - examples run cleanly @John Bl

Re: [VOTE] Apache Geode 1.7.0 RC1

+1 Reviewed LICENSE and NOTICE* Verified signatures and hashes Checked source releases for binaries Verified that source releases build successfully Confirmed that geode-examples run correctly Verified GitHub tag Anthony * I found a few places that need copyright date updates and will tweak thos