Build for version 1.8.0-build.1326 of Apache Geode failed.

2018-08-23 Thread apachegeodeci
= The build job for Apache Geode version 1.8.0-build.1326 has failed. Build artifacts are available at: http://files.apachegeode-ci.info/builds/1.8.0-build.1326/geode-build-artifacts-1.8.0-build.1326.

Admin API getMissingPersistentMembers is deprecated

2018-08-23 Thread Kirk Lund
There are a few distributed tests that are using deprecated Admin API to getMissingPersistentMembers. Does anyone know if there's a non-deprecated way to do this? vm2.invoke(() -> { DistributedSystemConfig config = defineDistributedSystem(getSystem(), ""); AdminDistributedSystem a

Build for version 1.8.0-build.1327 of Apache Geode failed.

2018-08-23 Thread apachegeodeci
= The build job for Apache Geode version 1.8.0-build.1327 has failed. Build artifacts are available at: http://files.apachegeode-ci.info/builds/1.8.0-build.1327/geode-build-artifacts-1.8.0-build.1327.

CacheServer.setNotifyBySubscription(true); not needed

2018-08-23 Thread Kirk Lund
I'm seeing this in quite a few newer tests: 1:CacheServer server = cacheRule.getCache().addCacheServer(); 2:server.setPort(0); 3:*server.setNotifyBySubscription(true);* 4:server.start(); Just want to point out that line 3 gets flagged as deprecated and is no longer needed. NotifyB

Build for version 1.8.0-build.1328 of Apache Geode failed.

2018-08-23 Thread apachegeodeci
= The build job for Apache Geode version 1.8.0-build.1328 has failed. Build artifacts are available at: http://files.apachegeode-ci.info/builds/1.8.0-build.1328/geode-build-artifacts-1.8.0-build.1328.

CacheServer.setNotifyBySubscription(false)

2018-08-23 Thread Kirk Lund
Question about CacheServer.setNotifyBySubscription(boolean) which is deprecated... The default is now TRUE. But I found a test that is setting it to FALSE. What is the preferred non-deprecated API for setting this to FALSE? * @deprecated as of 6.0.1. This method is no longer in use, by default

Re: Admin API getMissingPersistentMembers is deprecated

2018-08-23 Thread Dan Smith
I think this was replaced with a gfsh command that does the same thing. Unfortunately, we don't have a public java API for gfsh as far as I know. -Dan On Thu, Aug 23, 2018 at 1:50 PM, Kirk Lund wrote: > There are a few distributed tests that are using deprecated Admin API to > getMissingPersist

Re: CacheServer.setNotifyBySubscription(false)

2018-08-23 Thread Bruce Schuchardt
It looks like the alternative is to not invoke that method.  The parameter only used to issue a warning if set to /false/. On 8/23/18 2:23 PM, Kirk Lund wrote: Question about CacheServer.setNotifyBySubscription(boolean) which is deprecated... The default is now TRUE. But I found a test that is

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1018 was SUCCESSFUL (with 2423 tests)

2018-08-23 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1018 was successful. --- Scheduled 2425 tests in total. https://build.spring.io/browse/SGF-NAG-1018/ -- Thi

[DISCUSS] Remove CatchException testing dependency

2018-08-23 Thread Kirk Lund
We have a small number of tests using com.googlecode.catchexception.CatchException. This project isn't very active and AssertJ provides better support for testing expected exceptions and throwables. Most Geode developers are already using AssertJ for expected exceptions. I propose we update the fe

Re: [DISCUSS] Remove CatchException testing dependency

2018-08-23 Thread Kirk Lund
I goofed on #1. We should be using* org.assertj.core.api.**Assertions* directly, not *AssertionsForClassTypes*. 1) Basic assertion about an expected exception Use: org.assertj.core.api.Assertions.assertThatThrownBy Example from JdbcWriterTest: assertThatThrownBy(() -> writer.beforeUpdate(en

Re: CacheServer.setNotifyBySubscription(false)

2018-08-23 Thread Kirk Lund
Sounds like it's a warning that's no longer considered useful. Ok, I'll delete that line from the test. Thanks! On Thu, Aug 23, 2018 at 3:37 PM, Bruce Schuchardt wrote: > It looks like the alternative is to not invoke that method. The parameter > only used to issue a warning if set to /false/.

GitHub PR notifications

2018-08-23 Thread Anthony Baker
Hi all, I read a lot of PR emails from Geode, but I was noticing that those are not being archived on a public Geode mailing list. Is that correct? I suggest we create a notifications@g.a.o mailing list to make sure all discussion on PR’s is archived on an ASF mailing list. This pattern has b

Re: GitHub PR notifications

2018-08-23 Thread Jacob Barrett
I am pretty sure all PRs are logged to JIRA and then emailed from JIRA. > On Aug 23, 2018, at 8:06 PM, Anthony Baker wrote: > > Hi all, > > I read a lot of PR emails from Geode, but I was noticing that those are not > being archived on a public Geode mailing list. Is that correct? > > I sugg

Re: GitHub PR notifications

2018-08-23 Thread Anthony Baker
AFAICT, PR comments are added to the JIRA worklog but only JIRA comments are sent to issues@g.a.o . > On Aug 23, 2018, at 8:10 PM, Jacob Barrett wrote: > > I am pretty sure all PRs are logged to JIRA and then emailed from JIRA. > >> On Aug 23, 2018, at 8:06 PM, Anthony Bak

Re: GitHub PR notifications

2018-08-23 Thread Jacob Barrett
Must we get spammed with every thing that happens? It seems to me a log in GitHub, JIRA and email is obscene. All this email we get now just gets bulk deleted and I often miss important conversations. If we move it all to another email group and nobody registers for it then what’s the point. I