+1 "To be consistent with our
Java brothers I would suggest apache::geode::client::internal namespace and
headers located in the include/geode/internal directory."
On Wed, Dec 27, 2017 at 4:28 PM, Mark Hanson wrote:
> Sounds good to me. +1
>
> Thanks,
> Mark
> > On Dec 27, 2017, at 9:17 AM, Jaco
+1 for consistency
On 1/8/18 07:35, Ernest Burghardt wrote:
+1 "To be consistent with our
Java brothers I would suggest apache::geode::client::internal namespace and
headers located in the include/geode/internal directory."
On Wed, Dec 27, 2017 at 4:28 PM, Mark Hanson wrote:
Sounds good to
+1 for always using absolute path in our product code.
Also the server/locator launchers should be able to take a working-dir as
parameter to store all the stat/logs/config files.
On Fri, Jan 5, 2018 at 3:49 PM, Kirk Lund wrote:
> The from should be:
>
> this.viewFile = new File("locator" +
The ClusterStartupRule, LocatorStarterRule, and ServerStarterRule rules all
have withTempWorkingDir methods that should take care of this, as well.
These temporary directories should be removed as part of the rules @After
invocation.
On Mon, Jan 8, 2018 at 10:23 AM, Jinmei Liao wrote:
> +1 for
Should geode have a single method it uses to create File instances?
That way the code that determines the parent dir could be in one place.
On Mon, Jan 8, 2018 at 11:26 AM, Patrick Rhomberg
wrote:
> The ClusterStartupRule, LocatorStarterRule, and ServerStarterRule rules all
> have withTempWorki
=
The build job for Apache Geode version 1.5.0-build.278 has failed.
Build artifacts are available at:
http://files.apachegeode-ci.info/builds/1.5.0-build.278/geode-build-artifacts-1.5.0-build.278.tgz
Thank you Kirk for the amazing write-up!
I want to highlight that the problem of only having one kind of test goes
both ways. Frequently we might think that changing something on the unit
level is going to resolve a bug, but in reality the real world use case now
fails a little later. I think that
+1 for using @Rule for any file creation...
-Anil.
On Mon, Jan 8, 2018 at 11:26 AM, Patrick Rhomberg
wrote:
> The ClusterStartupRule, LocatorStarterRule, and ServerStarterRule rules all
> have withTempWorkingDir methods that should take care of this, as well.
> These temporary directories shou
Pipeline results can be found at:
Concourse:
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/AcceptanceTest/builds/116
I think this module was specifically added for running JMH benchmarks since
it's pulling in the JMH plugin. JMH is framework for easily writing
microbenchmarks.
I think it makes sense to put JMH benchmarks in the same package as the
code under tests, since you may end up writing a microbenchmark f
---
Spring Data GemFire > Nightly-ApacheGeode > #791 was successful.
---
Scheduled
2326 tests in total.
https://build.spring.io/browse/SGF-NAG-791/
--
This
We'll probably end up writing benchmarks for classes or methods that are
package-private, so that would be one reason to not create a special
benchmarks package.
On Mon, Jan 8, 2018 at 1:40 PM, Dan Smith wrote:
> I think this module was specifically added for running JMH benchmarks since
> it's
Actually, that's what is causing the problem. Those Rules are mutating the
system property "user.dir" at runtime which is not supposed to be mutated.
However, if we change all new File calls in product code to use
System.getProperty("user.dir") as the parent dir then the problem is fixed.
Another
I think if we can make it work, removing the benchmarks module and moving
the benchmarks into the module where the code they are testing resides
would be the ideal. Talking with Dan, this would result in a src/jmh/java
source directory in any module with benchmarks, which I think would result
in a
+1 for adding src/jmh/java to each module. I submitted a PR with that
change and a new benchmark in geode-core last year, but I ended up closing
it after a couple months. If anyone wants help, let me know.
On Mon, Jan 8, 2018 at 3:23 PM, Nick Reich wrote:
> I think if we can make it work, removi
Pipeline results can be found at:
Concourse:
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/FlakyTest/builds/97
Build Update for apache/geode
-
Build: #5465
Status: Broken
Duration: 8 minutes and 54 seconds
Commit: f905ea2 (develop)
Author: Darrel Schneider
Message: Merge pull request #1239 from dschneider-pivotal/feature/GEODE-4051
GEODE-4051: change StateMarkerMessage
Pipeline results can be found at:
Concourse:
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/67
Pipeline results can be found at:
Concourse:
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/FlakyTest/builds/99
Pipeline results can be found at:
Concourse:
https://concourse.apachegeode-ci.info/teams/main/pipelines/release-1.4.0/jobs/DistributedTest/builds/4
20 matches
Mail list logo
