Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/#review184151 --- Ship it! Ship It! - Ken Howe On Aug. 29, 2017, 10:46 p.m., J

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/#review184156 --- Ship it! geode-web/src/test/java/org/apache/geode/management/i

RE: Indxes and hints

One more question: As I am trying to create a situation where the disk is accessed as least as possible (with a select distinct from X where a=1 and b>10 and c=true; In which a and b are indexes and c is not, and c is in the value which is evicted to disk) Did I get it right - that if I use a

[GitHub] geode issue #748: GEODE-3472: Remove a great deal of commented-out code.

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/748 Precheckin green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode pull request #748: GEODE-3472: Remove a great deal of commented-out co...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/748 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: [VOTE] Apache Geode release - v1.2.1 RC1

We've found a problem with the fix for geode-3249 that should probably be corrected in the 1.2.1 release. On 8/29/17 12:07 PM, Anthony Baker wrote: I encourage the PMC members to review and vote so we can close out this release. Of course, all feedback is welcome. Thanks, Anthony On Aug 2

Review Request 61995: wip

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61995/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 61995: wip

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61995/#review184174 --- Ship it! Ship It! - Jared Stewart On Aug. 30, 2017, 5:38 p.m

[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...

Github user karensmolermiller closed the pull request at: https://github.com/apache/geode-examples/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] geode-examples issue #8: GEODE-3195 Add querying example to the geode-exampl...

Github user karensmolermiller commented on the issue: https://github.com/apache/geode-examples/pull/8 Closing this PR. Will resubmit a revised version of this example that addresses all review comments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode-examples pull request #15: GEODE-3195 Add querying example to the geod...

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-examples/pull/15 GEODE-3195 Add querying example to the geode-examples Please review this revised example of querying two ways: programmatically and through gfsh. You can merge this pull request i

Re: Indxes and hints

You will probably have to step through debugger for this one.. it really depends on the query. For this query, I expect the query engine to pick one index and run the rest of the criteria on the results of the first index used. My guess is you have created a CompactRangeIndex, and if so, you can

[Discuss] Use of -1 as Infinite/All for retry related functions...

Hi All, *Question: how should we deal in a very forward and clean fashion with the implicit ambiguity of -1 or all, or infinite, or forever?* *Background:* We are looking to get some feedback on the subject of infinite/all/forever in the geode/geode-native code. In looking at the code, we s

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- (Updated Aug. 30, 2017, 1:48 p.m.) Review request for geode, Alexander Murmann,

[GitHub] geode pull request #750: GEODE-3330 Document modified CQ authorization permi...

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/750 GEODE-3330 Document modified CQ authorization permissions @joeymcallister @davebarnes97 @jinmeiliao @kirklund @jaredjstewart Please review. You can merge this pull request into a Git r

Re: [Discuss] Use of -1 as Infinite/All for retry related functions...

Personally, I don't much like sentinel values, even if they have their occasional use. Do we need to provide an authentic infinite value? 64-bit MAXINT is nearly 10 quintillion. At 10GHz, that still takes almost three years. If each retry takes as much as 10ms, we're still looking at "retry for

[GitHub] geode pull request #750: GEODE-3330 Document modified CQ authorization permi...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[CANCEL][VOTE] Apache Geode release - v1.2.1 RC1

This vote is cancelled due to an error an in the fix for GEODE-3249. Anthony On Wed, Aug 30, 2017 at 10:25 AM, Bruce Schuchardt wrote: > We've found a problem with the fix for geode-3249 that should probably be > corrected in the 1.2.1 release. > > > > On 8/29/17 12:07 PM, Anthony Baker wrote:

Review Request 62001: GEODE-3525: Dockerize AcceptanceTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62001/ --- Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, Jared Stewart,

Re: [CANCEL][VOTE] Apache Geode release - v1.2.1 RC1

I've pushed the fix for the problem with geode-3249 to develop and cherry-picked it on the release/1.2.1 branch On 8/30/17 2:59 PM, Anthony Baker wrote: This vote is cancelled due to an error an in the fix for GEODE-3249. Anthony On Wed, Aug 30, 2017 at 10:25 AM, Bruce Schuchardt wrote: W

Review Request 62002: GEODE-3539: Add tests for List Members and Describe Member

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62002/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and P

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #663 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #663 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-663/ -- This

Build failed in Jenkins: Geode-nightly #939

See Changes: [jiliao] GEODE-3436: Restore refactoring of MemberCommands [jiliao] GEODE-3436: Restore refactoring of DurableClientCommands [jiliao] GEODE-3436: Restore refactoring of PDXCommands [jiliao] GEODE-3436

Build failed in Jenkins: Geode-nightly-flaky #107

See Changes: [jiliao] GEODE-3472: Remove a great deal of commented-out code. [jstewart] GEODE-2859: Fix race condition in ShowDeadlockDUnitTest [jiliao] GEODE-3539: add test for invalid command [bschuchardt]

Re: [Discuss] Use of -1 as Infinite/All for retry related functions...

-1 for using -1! Another option is to change the factory API to: withRetryAttempts(uint32_t retryAttempts) Will attempt no more than `retryAttempts`, may be less if all available servers are exhausted. withRetryAttemptsAllServers() Will retry on all servers. withoutRetryAttempts() Will not retr

Re: [Discuss] Use of -1 as Infinite/All for retry related functions...

In general, I think we need making the configuration of geode less complex, not more. As far as retry-attempts goes, maybe the best thing to do is to get rid of it. The P2P layer has no such concept. I don't think users should really have to care about how many servers an operation is attempted ag

Re: [Discuss] Use of -1 as Infinite/All for retry related functions...

That is a really good point. Does the retry attempts even make sense anymore? Does the Java client still have it? If so would it make sense to deprecate it there too? -Jake Sent from my iPhone > On Aug 30, 2017, at 8:36 PM, Dan Smith wrote: > > In general, I think we need making the configu

[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user dineshakhand closed the pull request at: https://github.com/apache/geode/pull/720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #720: GEODE-3462: FunctionStats Exposed over JMX

Github user dineshakhand commented on the issue: https://github.com/apache/geode/pull/720 Closing the pull rquest after your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea