[GitHub] geode issue #677: GEODE-3038: A server process shuts down quietly when path ...

Github user anton-mironenko commented on the issue: https://github.com/apache/geode/pull/677 Actually there is already a test which tests exactly this bug: org.apache.geode.cache30.CacheXml66DUnitTest#testNonExistentFile But I see that all the package org.apache.geode.cache30 is

RE: Indxes and hints

Thank you Jason :-) -Original Message- From: Jason Huynh [mailto:jhu...@pivotal.io] Sent: Monday, August 28, 2017 7:24 PM To: dev@geode.apache.org Subject: Re: Indxes and hints Hi Roi, Answers are below the questions... Question 1. Is it true to say, that the query as it is will load a

[GitHub] geode issue #745: GEODE-3436: Restore reverted GFSH command refactoring

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/745 Precheckin fully green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] geode pull request #745: GEODE-3436: Restore reverted GFSH command refactori...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/ --- (Updated Aug. 29, 2017, 4:53 p.m.) Review request for geode, Emily Yeh, Jared S

[GitHub] geode issue #677: GEODE-3038: A server process shuts down quietly when path ...

Github user anton-mironenko commented on the issue: https://github.com/apache/geode/pull/677 Well, this test category is DistributedTest, not Test. This is why I didn't see it in regular unit tests run. Now the question is - why this test doesn't fail, whereas it should fail with

[GitHub] geode issue #739: GEODE-3385: Change GetAllRequest to return list of errors.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/739 rebased on develop again, fixed a test to use the new MessageExecutionContext. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/#review184069 --- Ship it! Ship It! - Jinmei Liao On Aug. 29, 2017, 4:53 p.m.,

[GitHub] geode issue #746: GEODE-3529 move new client/server security classes to a di...

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/746 @bschuchardt try closing and reopening; I think that will make Travis restart. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Review Request 61950: GEODE-3519 servers are not locking on remove or invalidate ops initiated by clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61950/#review184078 --- Ship it! Ship It! - Alexander Murmann On Aug. 28, 2017, 4:09

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135870888 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -41,8 +41,8 @@ private synchronized voi

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135871243 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -57,15 +57,14 @@ private synchronized C

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135871358 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -57,15 +57,14 @@ private synchronized C

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/#review184081 --- Ship it! As an aside, I assume you post these things via script

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

> On Aug. 29, 2017, 6:42 p.m., Patrick Rhomberg wrote: > > As an aside, I assume you post these things via script. You're still > > tagging `eyeh`. Not that it really matters, since it's hooked ot a > > `pivotal` email, but still worth updating. Also looks like you're not tagging Jinmei or S

Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and P

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/739#discussion_r135883931 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -50,26 +53,52 @@

Re: [VOTE] Apache Geode release - v1.2.1 RC1

I encourage the PMC members to review and vote so we can close out this release. Of course, all feedback is welcome. Thanks, Anthony > On Aug 25, 2017, at 3:20 PM, Anthony Baker wrote: > > This is the first release candidate for Apache Geode, version 1.2.1. > Thanks to all the community membe

[GitHub] geode pull request #748: GEODE-3472: Remove a great deal of commented-out co...

GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/748 GEODE-3472: Remove a great deal of commented-out code. This pull request replaces #730. Nontrivial conflicts were introduced after rebasing against GEODE-3436 (`be8a13`). This

[GitHub] geode issue #730: GEODE-3472: Remove a great deal of commented-out code.

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/730 Due to significant changes, this pull request is replaced by #748. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/#review184083 --- Ship it! Ship It! - Jinmei Liao On Aug. 29, 2017, 7:03 p.m.,

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135888279 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -41,8 +41,8 @@ private synchronized v

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user bschuchardt closed the pull request at: https://github.com/apache/geode/pull/746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

GitHub user bschuchardt reopened a pull request: https://github.com/apache/geode/pull/746 GEODE-3529 move new client/server security classes to a different pac… @kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype The new classes/interfaces have been move

Re: [VOTE] Apache Geode release - v1.2.1 RC1

-1 for breaking change in client/server protocol. -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771 On Tue, Aug 29, 2017 at 3:07 PM, Anthony Baker wrote: > I encourage the PMC members to review and vote so we can close out this > release. Of course, all feedback

[GitHub] geode issue #746: GEODE-3529 move new client/server security classes to a di...

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/746 okay - travis ci passed this time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/749 GEODE-3502: Added awaitility clauses. * Added awaitility clauses while waiting for the stat comparison checks * Replaced the deprecated Wait Criterion with Awaitility clause with incre

[GitHub] geode issue #749: GEODE-3502: Added awaitility clauses.

Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/749 @ladyVader @jhuynh1 @upthewaterspout @boglesby -- Potential reviewers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] geode issue #747: GEODE-3514: Clean up locator and protobuf related code

Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/747 **DO NOT MERGE THIS YET. THIS IS STILL BASED ON A RED DEVELOP CHECKOUT** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/739#discussion_r135899858 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -50,26 +53,52 @@

Re: [VOTE] Apache Geode release - v1.2.1 RC1

Hi Mike! Thanks for your feedback. IMHO I don't consider GEODE-3249 to break client/server compatibility since there's a mechanism to disable the protocol change to allow clients to be upgraded. The process would look like this: 1) Upgrade servers and set the 'geode.allow-internal-messages-with

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

> On Aug. 29, 2017, 6:42 p.m., Patrick Rhomberg wrote: > > As an aside, I assume you post these things via script. You're still > > tagging `eyeh`. Not that it really matters, since it's hooked ot a > > `pivotal` email, but still worth updating. > > Patrick Rhomberg wrote: > Also looks l

Re: [VOTE] Apache Geode release - v1.2.1 RC1

I think in number 3 you mean remove flag and restart servers. That should work. Ok, +1 -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771 On Tue, Aug 29, 2017 at 4:38 PM, Anthony Baker wrote: > Hi Mike! > > Thanks for your feedback. IMHO I don't consider GEODE-3

Re: [VOTE] Apache Geode release - v1.2.1 RC1

I am not filling your upgrade steps? You say upgrade clients in both steps 2 and 3. What does that mean? Sent from my iPhone > On Aug 29, 2017, at 1:38 PM, Anthony Baker wrote: > > Hi Mike! > > Thanks for your feedback. IMHO I don't consider GEODE-3249 to break > client/server compatibility

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,

[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/ --- (Updated Aug. 29, 2017, 10:46 p.m.) Review request for geode, Jinmei Liao, Jare

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #662 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #662 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-662/ -- This

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184098 --- The refactor is awesome! It would be nice though to have a test t

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- (Updated Aug. 29, 2017, 3:52 p.m.) Review request for geode, Alexander Murmann,

Build failed in Jenkins: Geode-nightly #938

See Changes: [upthewaterspout] GEODE-3513: Removing the use of native sessions session caching [klund] GEODE-3527: increase timeouts for file deletion [klund] GEODE-3527: use consistent value for all timeouts [kl

Build failed in Jenkins: Geode-nightly-flaky #106

See Changes: [jiliao] GEODE-3436: Restore refactoring of MemberCommands [jiliao] GEODE-3436: Restore refactoring of DurableClientCommands [jiliao] GEODE-3436: Restore refactoring of PDXCommands [jiliao] GEOD