[GitHub] geode pull request #664: Fix for GEODE-3292

2017-07-28 Thread jujoramos
GitHub user jujoramos opened a pull request: https://github.com/apache/geode/pull/664 Fix for GEODE-3292 Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost - ManagementAgent sets the 'pulse.host' system property whenever a 'jmx-manager-bind-address

Re: Review Request 61196: GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure

2017-07-28 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61196/#review181674 --- Ship it! Ship It! - Ken Howe On July 27, 2017, 10:22 p.m., J

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

2017-07-28 Thread pivotal-amurmann
Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/663 I am sure it would be hard, but could we please write a unit test for the change that was made to `DLockService#unlock`? --- If your project is set up for it, you can reply to this email and

[GitHub] geode issue #660: GEODE-2924 Revise authorization permissions

2017-07-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/660 +1. For future reference, tickets GEODE-2920 through GEODE-2926 were committed under the overarching ticket [GEODE-2919](https://issues.apache.org/jira/browse/GEODE-2919) in commit `451d12e8..

[GitHub] geode issue #663: GEODE-3314: Fix DLockService token leak.

2017-07-28 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/663 We probably can write a unit test. In particular, it would be nice if we could test this bug without starting a whole `Cache`. --- If your project is set up for it, you can reply to this email

[GitHub] geode pull request #660: GEODE-2924 Revise authorization permissions

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 61196: GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure

2017-07-28 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61196/#review181685 --- Ship it! Ship It! - Jinmei Liao On July 27, 2017, 10:22 p.m.

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-07-28 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181686 --- Ship it! Some javadoc on how to use thes test utilities would b

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-07-28 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/665 GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3254) `ConfigCommands.java` was a large class tha

Build failed in Jenkins: Geode-nightly #909

2017-07-28 Thread Apache Jenkins Server
See Changes: [ukohlmeyer] GEODE-3192,GEODE-3229: Change API and implementation of protobuf PutAll. [jiliao] GEODE-3231: use tempWorkingFolder to avoid test log file contamination [nnag] GEODE-3301: Cargo installs

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

2017-07-28 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/666 GEODE-3329: Changed logging output of modify_war script Changed the modify_war script so that its output and error streams write to a log file instead of to standard out. Thank you for s

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

2017-07-28 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/666 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou @PurelyApplied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Review Request 61224: GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest

2017-07-28 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61224/ --- Review request for geode, Emily Yeh, Galen O'Sullivan, Jared Stewart, Ken Howe,

[GitHub] geode issue #591: GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByCo...

2017-07-28 Thread YehEmily
Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/591 @kirklund The conflicts have been fixed! Thanks for looking over this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Review Request 61224: GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest

2017-07-28 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61224/#review181715 --- Ship it! Ship It! - Jinmei Liao On July 28, 2017, 6:23 p.m.,

Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

2017-07-28 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61231/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

2017-07-28 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/666 Thanks for the quick turn around on this! +0.5, since I don't really know this corner of the code, but it looks good to me! --- If your project is set up for it, you can reply to this email an

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-07-28 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated July 28, 2017, 10:46 p.m.) Review request for geode, Emily Yeh, Jared

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #630 was SUCCESSFUL (with 1987 tests). Change made by John Blum.

2017-07-28 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #630 was successful. --- Scheduled with changes by John Blum. 1989 tests in total. https://build.spring.io/browse

[GitHub] geode pull request #667: GEODE-3324 Document finer-grained security permissi...

2017-07-28 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/667 GEODE-3324 Document finer-grained security permissions @jinmeiliao @PurelyApplied @jaredjstewart @joeymcallister @davebarnes97 Please review. You can merge this pull request into a

new Wiki page on Locator internals

2017-07-28 Thread Bruce Schuchardt
Ever wonder what's in a Geode Locator? https://cwiki.apache.org/confluence/display/GEODE/Locator+Architecture

Re: GMSJoinLeaveJUnitTest failing on develop

2017-07-28 Thread Bruce Schuchardt
(GEODE-3155) GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess failing in CI This was caused by a checkin from Hitesh on 7/14 On 7/27/17 4:43 PM, Patrick Rhomberg wrote: I don't see a JIRA for it, but it's been failing sporadically for me on my precheckins. On Tue, Jul 25, 2017 at 10:4

Re: GMSJoinLeaveJUnitTest failing on develop

2017-07-28 Thread Galen O'Sullivan
I just filed GEODE- for GMSJoinLeaveJUnitTest. testViewNotSentWhenShuttingDown . I've gotten a failure from the command line, but not when I run it from within IntelliJ (even repeatedly). On Fri, Jul 28, 2017 at 4:12 PM, Bruce Schuchardt wrote: > (GEODE-3155) GMSJoinLeaveJUnitTest.testCoordi