Re: org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-18 Thread John Blum
Thanks Kirk and team! +1 for bubbling up some of the internal APIs and having consistency and/or functional parity. One suggestion is, perhaps a quick note could be sent out to the Geode devs with a title/subject of "*NOTICE: Frameworks/Tooling*" with a body detailing the API (public/internal) ch

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-18 Thread Kirk Lund
I think we should definitely try to refactor any Geode internals that SDG is using to be public API or SPI. We'll need to take a closer look at how SDG is using those classes to plan what to do. If I change or any classes on your list (or public APIs), I'll give you heads up next time. On Thu, Ma

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-18 Thread John Blum
Hi Kirk (also responding to Bruce as I was writing this before he sent)- Thank you for following up. Regarding the addition of the getOnlineLocators()... SDG does implement

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-18 Thread Bruce Schuchardt
John, is it possible to list the internal APIs needed by SDG? I don't think we can live with a requirement that all internal API changes need to be communicated and blessed. We need to address SDG's needs in the public APIs and get rid of this dependency. Le 5/18/2017 à 9:36 AM, Kirk Lund a

Re: org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-18 Thread Kirk Lund
Hi John! How did the addition of getOnlineLocators() cause SDG build to fail? I checked [9] but I couldn't quite grok what happened. I would've thought that adding would be ok but removing could potentially break SDG. The InternalDataSerializer change was probably mine. I reduced scope of methods

org.apache.geode.internal.InternalDataSerializer API Changes...

2017-05-17 Thread John Blum
Geode devs- I am not sure how decisions are made when changing Geode's API, but I would caution that more care should be taken when doing so, regardless of whether the APIs are public or not, but especially when they are public. Unfortunately, in this particular case, the API in question is deeme