Re: export logs and stats

2017-03-01 Thread Darrel Schneider
The code that gets the list of old logs/stats to remove is: org.apache.geode.internal.io.MainWithChildrenRollingFileHandler.checkDiskSpace(String, File, long, File, LogWriterI18n) You will see that it calls findChildrenExcept with a pattern. You probably want to instead call findChildren and you w

Re: export logs and stats

2017-03-01 Thread Darrel Schneider
IndexOutOfBoundError if you don't specify an extension is a bug that should be fixed. It could be fixed by tacking on a default extension if one does not exist. I'm not sure what should be done about filenames with multiple "." in them (like "foo.log.gz"). Currently I think the code says what come

Re: export logs and stats

2017-02-28 Thread Swapnil Bawaskar
+1 for restricting the file extensions and looking at what the user has defined. On Tue, Feb 28, 2017 at 4:46 PM Jinmei Liao wrote: > Yeah, before we were simply looking at System.getProperty("user.dir") to > get all the logs/stats, now I think we should use whatever user defined in > the config

Re: export logs and stats

2017-02-28 Thread Jinmei Liao
Yeah, before we were simply looking at System.getProperty("user.dir") to get all the logs/stats, now I think we should use whatever user defined in the config file and do a getParent to get the parent directory to search for the files. On Tue, Feb 28, 2017 at 4:34 PM, Dan Smith wrote: > I think

Re: export logs and stats

2017-02-28 Thread Dan Smith
I think maybe I didn't quite understand the original proposal. Are you saying you won't even look at the directory or filename the user specifies, but just grab all the files that happen to be in the working directory and end in .log? I don't think that's going to do the right thing for most users.

Re: export logs and stats

2017-02-28 Thread Jinmei Liao
Darrel, it seems if user defines a log file to be simply "serverLog" (a filename with no "."), when rolling over the log file once file size is reached, we get a IndexOutOfBoundError when it's trying to figure out what's the rolled-over filename should be. And if user defines a log file name to be

Re: export logs and stats

2017-02-28 Thread Jinmei Liao
Darrel, great, can you point me to the code to get a list of the files to copy? On Tue, Feb 28, 2017 at 3:16 PM, Darrel Schneider wrote: > It sounds like you will pick up any file in the working directory that ends > with ".log" or ".log.gz". > But what if the geode server is sharing a directory

Re: export logs and stats

2017-02-28 Thread Darrel Schneider
It sounds like you will pick up any file in the working directory that ends with ".log" or ".log.gz". But what if the geode server is sharing a directory with something else that is also writing files with these extensions? Or if multiple geode servers are running in the same directory? I think it

Re: export logs and stats

2017-02-28 Thread Jinmei Liao
I think restriction1) also has something to do with not needing to parse the file path/names. If you define an absolute path, we will need to parse the string to get the directory and file name. Besides, if all the logs are already written to a centralized place, just zip them up and send it over,

Re: export logs and stats

2017-02-28 Thread Dan Smith
I'm a bit confused by (1). Isn't it actually more complicated for you to restrict log collection to a relative path? Why not just look for log files no matter where they are written to? I also don't really follow the argument about why a user that writes to /var/logs is not going to want to use thi

export logs and stats

2017-02-28 Thread Jinmei Liao
Hello community, We are currently trying to improve what "export logs" should do. Currently export logs only export the logs(filtered by logLevel and start and end date) to each individual member's file system. We want to make all the member's logs exported to a central location and if you are co