Re: Weird intermittent build error caused by spotlessJava

2019-03-27 Thread Patrick Rhomberg
I suppose that's true, yes -- if the branch is old enough that it predates our work to improve the gradle correctness, then sure, that work isn't there to guarantee correctness of the older build. But if your branch is as recent as the last few months, then Gradle should notice the changes in the

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Kirk Lund
Are you sure it's not necessary to do a clean build when switching between different branches? Especially branches that are far enough apart in revisions that their gradle build files are different? Sometimes two branches, such as for two different releases, are significantly different in the gradl

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Patrick Rhomberg
As Dan mentioned, the few times I've seen this has been a result of running clean in the same build set as spotless. While that "shouldn't" be an issue, it seems to be the underlying cause. I encourage you to not clean every time you build. We've done a lot of work lately to improve the correctn

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Kirk Lund
I actually have two lines in my gradle.properties. The combo seems to make spotless behave when it gets into the broken state I mentioned before: org.gradle.daemon=false org.gradle.parallel=false This does make it slower but slower is better than broken. On Tue, Mar 26, 2019 at 11:38 AM Kirk Lun

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Kirk Lund
I just had this occur again. And I found another solution, albeit not a great one, but if you disable org.gradle.daemon that also clears up this problem. You can add this to ~/.gradle/gradle.properties: org.gradle.daemon=false Just to clarify, I'm on a Mac using gradlew in geode (I don't have my

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Kirk Lund
Few more details that might help others... Each Geode module fails in the same way but obviously on a different .java file, and I have not altered these .java files -- they do not appear to have any format issues involving imports. Once gradle is in this state, switching branches from a feature b

Re: Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Dan Smith
I have had several issues running clean in combination with other gradle commands - I think because of our parallel build. Maybe do this? $ ./gradlew clean; ./gradlew build -xtest On Tue, Mar 26, 2019 at 10:43 AM Kirk Lund wrote: > Intermittent build error caused by spotlessJava. My checkout of

Weird intermittent build error caused by spotlessJava

2019-03-26 Thread Kirk Lund
Intermittent build error caused by spotlessJava. My checkout of Geode intermittently gets into a state that then fails to build. I've been seeing this come and go for the last month or two. I'm not sure what puts it into this state but executing: $ ./gradlew clean build -x test ...will repeatedly