Re: Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Udo Kohlmeyer
1) I think this discussion should be on another thread 2) I don't know if this is something that could be that easily changed per region. On 5/15/17 16:40, Michael Stolz wrote: While we are going down this path, could read-serialized be a Region property? -- Mike Stolz Principal Engineer -

Re: Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Michael Stolz
While we are going down this path, could read-serialized be a Region property? -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On May 15, 2017 7:22 PM, "Jacob Barrett" wrote: > This is an awesome step forward! > > We are getting close to committing similar refact

Re: Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Jacob Barrett
This is an awesome step forward! We are getting close to committing similar refactoring on the C++ client to move away from globals too. Death to globals! -Jake On Mon, May 15, 2017 at 1:03 PM Kirk Lund wrote: > I just merged in a big refactoring which changes classes that were using > GemFir

Re: Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Galen M O'Sullivan
Thanks for making this critical refactoring work happen, Kirk! The day of two Caches in a single JVM seems just a little bit closer now. On Mon, May 15, 2017 at 1:31 PM, Dan Smith wrote: > +googol - you're awesome Kirk, thanks for taking this on! > > -Dan > > On Mon, May 15, 2017 at 1:03 PM, Kir

Re: Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Dan Smith
+googol - you're awesome Kirk, thanks for taking this on! -Dan On Mon, May 15, 2017 at 1:03 PM, Kirk Lund wrote: > I just merged in a big refactoring which changes classes that were using > GemFireCacheImpl to using InternalCache. > > InternalCache is an interface representing the internal view

Use InternalCache instead of GemFireCacheImpl

2017-05-15 Thread Kirk Lund
I just merged in a big refactoring which changes classes that were using GemFireCacheImpl to using InternalCache. InternalCache is an interface representing the internal view of Cache which exposes all the operations that aren't exposed in the User API of Cache or GemFireCache. InternalCache and G

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-20 Thread Kirk Lund
, Jinmei Liao, Jared Stewart, Ken Howe, and Dan Smith. Bugs: GEODE-2632 https://issues.apache.org/jira/browse/GEODE-2632 Repository: geode Description --- GEODE-2632 refactoring part 5 GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl * minor cleanup: delete

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-20 Thread Galen O'Sullivan
request for geode, Jason Huynh, Jinmei Liao, Jared Stewart, Ken Howe, > and Dan Smith. > > > Bugs: GEODE-2632 > https://issues.apache.org/jira/browse/GEODE-2632 > > > Repository: geode > > > Description > --- > > GEODE-2632 refactoring part 5

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-19 Thread Kirk Lund
, Jinmei Liao, Jared Stewart, Ken Howe, and Dan Smith. Bugs: GEODE-2632 https://issues.apache.org/jira/browse/GEODE-2632 Repository: geode Description --- GEODE-2632 refactoring part 5 GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl * minor cleanup: delete

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-19 Thread Kirk Lund
: refactor code to use InternalCache instead of GemFireCacheImpl * minor cleanup: delete dead-code and useless javadocs/comments, reduce scope of vars/methods/constants, misc IDE warnings Diffs (updated) - geode-core/src/main/java/org/apache/geode/cache/query/internal/cq

Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-19 Thread Kirk Lund
, and Dan Smith. Bugs: GEODE-2632 https://issues.apache.org/jira/browse/GEODE-2632 Repository: geode Description --- GEODE-2632 refactoring part 5 GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl * minor cleanup: delete dead-code and useless javadocs/comments