Yep I'm selecting the geode repo.
I'll try to submit this one as a PR. I wanted to make sure the Travis
changes are working anyway.
Thanks,
Kirk
On Thu, Dec 8, 2016 at 2:15 PM, Dan Smith wrote:
> Cool. I just wanted to make sure the base of your diff was a valid
> revision. Your git diff comm
Cool. I just wanted to make sure the base of your diff was a valid
revision. Your git diff command with three dots will generate a diff of
your HEAD against that revision.
That's definitely a valid revision, it's still no develop (no one forced
pushed it!) And I was able to create a review request
I'm not sure what it should be but here's the output...
$ git merge-base HEAD origin/develop
ef7418140b903e73bc3a38d3a86c01349924bd09
On Thu, Dec 8, 2016 at 12:49 PM, Dan Smith wrote:
> What does git merge-base HEAD origin/develop tell you? That's the revision
> it's generated a diff against.
What does git merge-base HEAD origin/develop tell you? That's the revision
it's generated a diff against. You could try fetching from origin and
rebasing your branch on origin/develop to help.
-Dan
On Thu, Dec 8, 2016 at 9:23 AM, Kirk Lund wrote:
> I'm unable to post any reviews for Apache Geod
Usually, I just ran the following command under in my feature branch:
rbt post --repository geode --tracking-branch=origin/develop
--target-groups=geode
It will post the diff between my branch and develop automatically.
On Thu, Dec 8, 2016 at 12:23 PM, Kirk Lund wrote:
> The web gui.
>
> On Thu
The web gui.
On Thu, Dec 8, 2016 at 11:31 AM Anthony Baker wrote:
> Are you trying to post reviews using `rbt post` or the web gui?
>
>
>
> Anthony
>
>
>
>
>
> > On Dec 8, 2016, at 9:23 AM, Kirk Lund wrote:
>
> >
>
> > I'm unable to post any reviews for Apache Geode on
>
> > https://reviews.apa
Are you trying to post reviews using `rbt post` or the web gui?
Anthony
> On Dec 8, 2016, at 9:23 AM, Kirk Lund wrote:
>
> I'm unable to post any reviews for Apache Geode on
> https://reviews.apache.org
>
> I've updated .git/config in my checkout to match the non-incubator URL for
> asf git.
I'm unable to post any reviews for Apache Geode on
https://reviews.apache.org
I've updated .git/config in my checkout to match the non-incubator URL for
asf git. I've also rebased on latest origin/develop, but every time I try
to upload my diff file, I get this error...
The specified diff file co
