Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread Kirk Lund
This looks great John! I'll spend some time going through all of this soon. Thanks! On Fri, Aug 10, 2018 at 10:04 AM, John Blum wrote: > If you haven't seen this, you should have a look at *Spring Test for Apache > Geode* (STDG) [1] > > I have much work to do yet to round this project out: docs,

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread Kirk Lund
Sounds good! I'll be offline next week but available to join in on this or anything else after that. On Fri, Aug 10, 2018 at 12:14 PM, Jacob Barrett wrote: > I think we are on the same page but maybe disagree on some details. I’m > more than happy to go further in refactoring this testing mess i

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread Jacob Barrett
I think we are on the same page but maybe disagree on some details. I’m more than happy to go further in refactoring this testing mess into additional modules. We can even have a more clear outline of what goes in each test module. The current effort to fix inter project test dependencies is n

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread John Blum
If you haven't seen this, you should have a look at *Spring Test for Apache Geode* (STDG) [1] I have much work to do yet to round this project out: docs, more "formalized" integration test support (think JUnit Rules and custom Runners over extension, etc) and so on. However, mocking for Geode Obj

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread Kirk Lund
In my opinion geode-junit and geode-dunit should be treated as testing frameworks that users can use to build better geode tests with. Think JUnit or Mockito here. We have some valuable rules and dunit is valuable framework for more than building geode. We've been talking about providing this to us

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-10 Thread Jacob Barrett
I am not sure why you think geode-junit and geode-dunit are production jars and should be treated as such. They are test framework jars in the same vein as org.springframework:spring-test or org.apache.lucene:lucene-test-framework. The should contain shared class for producing tests against the geo

Re: Testing code in geode-junit and geode-dunit src/main

2018-08-09 Thread Jacob Barrett
I see those tests in the main. I’m correcting those in an upcoming pr. Looks like they are tests for shared test classes so they will go in geode-dunit/src/test. I’ll update this email after I burn through them. > On Aug 9, 2018, at 3:56 PM, Kirk Lund wrote: > > We now have geode-junit and ge

Testing code in geode-junit and geode-dunit src/main

2018-08-09 Thread Kirk Lund
We now have geode-junit and geode-dunit modules which contain the testing frameworks and rules that we've been using in Geode tests. These are also being published to maven and have release jars. Yay! There is some code however that was moved from src/test of various modules into the src/main of b