Re: Review needed for c++ client ticket

2020-07-30 Thread Jacob Barrett
The PR needs tests. > On Jul 30, 2020, at 7:38 AM, Blake Bender wrote: > > Hi Alberto, > > I've reached out to Jake to approve his review, then I'll merge this for you. > Sorry for the delay. > > Thanks, > > Blake > > > On 7/23/20, 3:08 AM, "Alberto Bustamante Reyes" > wrote: > >H

Re: Review needed for c++ client ticket

2020-07-30 Thread Blake Bender
Hi Alberto, I've reached out to Jake to approve his review, then I'll merge this for you. Sorry for the delay. Thanks, Blake On 7/23/20, 3:08 AM, "Alberto Bustamante Reyes" wrote: Hi, Could someone please take a look at this c++ client PR? https://nam04.safelinks.protection.out

Review needed for c++ client ticket

2020-07-23 Thread Alberto Bustamante Reyes
Hi, Could someone please take a look at this c++ client PR? https://github.com/apache/geode-native/pull/628 It solves a problem reported in the users list: https://markmail.org/thread/gajd4ok65w227fhl Thanks, Alberto B.