Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-11 Thread Jared Stewart
> On Sept. 11, 2017, 4:54 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshStartLocatorLogTest.java > > Line 36 (original), 33 (patched) > > > > > > I t

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/#review185108 --- Ship it! Ship It! - Jared Stewart On Sept. 9, 2017, 6:21 a.m

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-11 Thread Jinmei Liao
> On Sept. 11, 2017, 4:54 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshStartLocatorLogTest.java > > Line 36 (original), 33 (patched) > > > > > > I t

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/#review185086 --- geode-assembly/src/test/java/org/apache/geode/management/internal

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-08 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/ --- (Updated Sept. 9, 2017, 6:21 a.m.) Review request for geode, Jared Stewart, Ken

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-08 Thread Jinmei Liao
> On Sept. 7, 2017, 11:27 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java > > Lines 37 (patched) > > > > > > I don't think this method is used. I

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-08 Thread Jinmei Liao
> On Sept. 7, 2017, 6:03 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommand.java > > Line 132 (original), 119-124 (patched) > > > > > > Si

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-08 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/ --- (Updated Sept. 9, 2017, 6:20 a.m.) Review request for geode, Jared Stewart, Ken

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-07 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/#review184901 --- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gf

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-07 Thread Patrick Rhomberg
> On Sept. 7, 2017, 6:03 p.m., Patrick Rhomberg wrote: > > Overall: I love how much is getting pruned! > > > > I like to run inspections with the `Changed Files` scope to clean up some > > of the low-hanging fruit. In particular, I get rankled by > > * Missorted modifiers (`ExportLogsCommand`)

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-07 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/#review184843 --- Overall: I love how much is getting pruned! I like to run inspect

Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

2017-09-07 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/ --- Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhombe