Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-09 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182529 --- Ship it! Ship It! - Emily Yeh On Aug. 3, 2017, 5:12 p.m., Ji

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-04 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182227 --- Ship it! Ship It! - Ken Howe On Aug. 3, 2017, 5:12 p.m., Jin

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-04 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182225 --- Ship it! I think this is a good improvement to the rule's API.

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-03 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182131 --- Ship it! Ship It! - Kirk Lund On Aug. 3, 2017, 5:12 p.m., Ji

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/ --- (Updated Aug. 3, 2017, 5:12 p.m.) Review request for geode, Emily Yeh, Jared St

Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-03 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat