Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/#review175271 --- Ship it! Ship It! - Jared Stewart On May 17, 2017, 4:39 p.m.

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jinmei Liao
> On May 16, 2017, 11:07 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java > > Lines 38 (patched) > > > > > > I was a bit surprised that these `set` m

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/ --- (Updated May 17, 2017, 4:39 p.m.) Review request for geode, Jared Stewart, Ken

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-16 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/#review175171 --- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/Em

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-16 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/ --- (Updated May 16, 2017, 10:48 p.m.) Review request for geode, Jared Stewart, Ken

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-16 Thread Jinmei Liao
> On May 16, 2017, 6:59 p.m., Kirk Lund wrote: > > geode-pulse/src/main/resources/log4j2.properties > > Lines 17 (patched) > > > > > > Everything in this file is commented out? > > > > Also, all of the other

Re: Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-16 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/#review175139 --- geode-pulse/src/main/resources/log4j2.properties Lines 17 (patche

Review Request 59316: GEODE-2927: fix pulse logging and useLocator, SSL flags

2017-05-16 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59316/ --- Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhombe