Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-15 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/ --- (Updated May 15, 2017, 6:33 p.m.) Review request for geode. Changes ---

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/#review174743 --- Ship it! Ship It! - Darrel Schneider On May 11, 2017, 2:45 p

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/#review174742 --- Ship it! Ship It! - Jinmei Liao On May 11, 2017, 9:45 p.m.,

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/ --- (Updated May 11, 2017, 9:45 p.m.) Review request for geode. Changes ---

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Jared Stewart
> On May 11, 2017, 9:38 p.m., Darrel Schneider wrote: > > Instead of having CacheLoader extend Declarable I think you should have > > changed CacheCallback to extends Declarable. > > CacheLoader is too narrow. So is CacheLoader and CacheListener. I know the > > jira ticket focused on CacheLoade

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/#review174733 --- Instead of having CacheLoader extend Declarable I think you should

Re: Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/#review174732 --- Ship it! Ship It! - Jinmei Liao On May 11, 2017, 9:16 p.m.,

Review Request 59206: GEODE-2836: CacheLoader now extends Declarable

2017-05-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59206/ --- Review request for geode. Repository: geode Description --- GEODE-2836: