Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 26, 2017, 4:39 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 26, 2017, 12:26 a.m.) Review request for geode, Darrel Schneider

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/#review173004 --- Ship it! Ship It! - Jared Stewart On April 25, 2017, 11:29 p

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 25, 2017, 11:29 p.m.) Review request for geode, Darrel Schneider

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 25, 2017, 11:27 p.m.) Review request for geode, Darrel Schneider

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
> On April 25, 2017, 9:05 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/cache/Cache.java > > Line 390 (original), 387 (patched) > > > > > > This method appears to be unused. That's actuall

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
> On April 25, 2017, 8:42 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > > Lines 2804-2811 (original), 2600-2607 (patched) > > > > > > Here and thr

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/#review172967 --- geode-core/src/main/java/org/apache/geode/cache/Cache.java Line 3

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/#review172966 --- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireC

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 25, 2017, 5:05 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- (Updated April 25, 2017, 5:04 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/#review172947 --- I'm not sure how the final key word got added to several methods.

Review Request 58712: GEODE-2632: partial cleanup of GemFireCacheImpl

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58712/ --- Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken Howe