Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-13 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58397/#review171896 --- Ship it! Ship It! - Eric Shu On April 12, 2017, 11:42 p.m.,

Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58397/ --- (Updated April 12, 2017, 4:42 p.m.) Review request for geode, anilkumar gingade

Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread Darrel Schneider
> On April 12, 2017, 2:50 p.m., Eric Shu wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java > > Lines 294 (patched) > > > > > > lruStatistics or stats passed in? Good

Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread Darrel Schneider
> On April 12, 2017, 3:44 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUCapacityController.java > > Line 283 (original), 274 (patched) > > > > > > Is it more r

Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58397/#review171803 --- geode-core/src/main/java/org/apache/geode/internal/cache/lru/Heap

Re: Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58397/#review171801 --- geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUC

Review Request 58397: check off-heap limit during disk recovery

2017-04-12 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58397/ --- Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat. Bugs: