Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 23, 2017, 5:39 p.m., Jared Stewart wrote: > > Is there a log4j configuration being applied somewhere? I'm wondering > > where I should expect the new Pulse logs to show up. I'm not entirely clear on how log4j workst. That said... All the pulse loggers are now being instantiated di

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 24, 2017, 4:10 p.m., Jinmei Liao wrote: > > We will need to verify that the logs went to the same place as before, or > > at least went to a reasonable place. [The below should be struck-through but isn't rendering that way on my end...] ~~It appears that, at least in my testing, the

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review170022 --- We will need to verify that the logs went to the same place as bef

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169899 --- Is there a log4j configuration being applied somewhere? I'm wonde

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/ --- (Updated March 22, 2017, 10:33 p.m.) Review request for geode, Jinmei Liao, Jar

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 11:36 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Lines 31 (patched) > > > > > > I just noticed this line. Pulse should NOT require geode-core and > > geode-common because it is a p

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 11:36 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Lines 31 (patched) > > > > > > I just noticed this line. Pulse should NOT require geode-core and > > geode-common because it is a p

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 3:28 p.m., Kirk Lund wrote: > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > > Line 87 (original), 89 (patched) > > > > > > Pulse has localization resour

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 10:28 p.m., Kirk Lund wrote: > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > > Line 87 (original), 89 (patched) > > > > > > Pulse has localization resou

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 11:36 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Lines 31 (patched) > > > > > > I just noticed this line. Pulse should NOT require geode-core and > > geode-common because it is a p

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169644 --- geode-pulse/build.gradle Lines 31 (patched)

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169628 --- The localization resource bundles in Pulse require some thought (d

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Line 70 (original) > > > > > > you only updated one test class which doesn't need logging at all. > > Let's not introduce this test

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Line 70 (original) > > > > > > you only updated one test class which doesn't need logging at all. > > Let's not introduce this test

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169629 --- geode-pulse/build.gradle Line 70 (original)

Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/ --- Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Ki