Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 13, 2017, 8:52 p.m., Anthony Baker wrote: > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > > Line 453 (original), 464 (patched) > > > > > > How much did this

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/#review168829 --- geode-core/src/main/java/org/apache/geode/internal/security/Integ

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/ --- (Updated March 13, 2017, 5:54 p.m.) Review request for geode, Jared Stewart, Ke

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 10, 2017, 12:51 a.m., Kirk Lund wrote: > > I really don't think these changes (removal of one call stack for the > > overridden methods) are going to improve performance. For code clarity, I'd > > really prefer to not make this change. My recommendation is to discard > > these chang

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/#review168567 --- I really don't think these changes (removal of one call stack for

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

> On March 9, 2017, 6:27 p.m., Kirk Lund wrote: > > Here's the change I recommend for improving performance. The problem is > > this line... > > > > private static SecurityService defaultInstance = new > > IntegratedSecurityService(); > > > > It always installs a IntegratedSecurityService. Br

Re: Review Request 57466: GEODE-2632: check if it is integrated security early in the call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/#review168485 --- Here's the change I recommend for improving performance. The probl

Review Request 57466: GEODE-2632: check if it is integrated security early in the call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57466/ --- Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.