Re: Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
> On Feb. 23, 2017, 7:30 p.m., Jason Huynh wrote: > > Looks good. Would it be helpful to add which event caused the exception as > > well? That might be a good idea - although it some cases it might not be a single event, but the whole batch. If we want that I can add it in a later commit.

Re: Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/#review166556 --- Ship it! Looks good. Would it be helpful to add which event ca

Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/ --- Review request for geode, Jason Huynh and Lynn Hughes-Godfrey. Repository: geod