Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-13 Thread Udo Kohlmeyer
> On Feb. 11, 2017, 1 a.m., Dan Smith wrote: > > geode-core/src/main/java/org/apache/geode/internal/hll/Bits.java, line 14 > > > > > > Technically, the hyperloglog stuff wasn't introduced for redis. But > > maybe it'

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/#review165220 --- This is changing the name and moving a class that is part of the p

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/ --- (Updated Feb. 10, 2017, 11:22 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/ --- (Updated Feb. 10, 2017, 10:49 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
> On Feb. 10, 2017, 9:44 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java, > > line 22 > > > > > > Make this some generic interface which can be used by any othe

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
> On Feb. 10, 2017, 10:17 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java, line > > 721 > > > > > > remove dead code We will raise a GEODE ticket to confirm t

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/#review165183 --- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireC

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/ --- (Updated Feb. 10, 2017, 9:45 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/#review165181 --- geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService

Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56564/ --- Review request for geode, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra, a