Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165197 --- Ship it! Ship It! - Jared Stewart On Feb. 10, 2017, 11:11 p.

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/ --- (Updated Feb. 10, 2017, 11:11 p.m.) Review request for geode, Anthony Baker, an

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/ --- (Updated Feb. 10, 2017, 11:08 p.m.) Review request for geode, Anthony Baker, an

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
> On Feb. 10, 2017, 10:29 p.m., Kirk Lund wrote: > > gradle/dependency-versions.properties, line 111 > > > > > > This change also requires corresponding change to these files: > > > > * > > geode-docs/tools

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165184 --- gradle/dependency-versions.properties (line 59)

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Kirk Lund
> On Feb. 10, 2017, 7:42 p.m., Jared Stewart wrote: > > It looks like > > org.apache.geode.internal.cache.tier.sockets.command.CreateRegionTest has > > an unused import that causes compilation to fail for me when I apply the > > patch: > > > > import org.apache.regexp.RE; This is now fixed b

Re: Review Request 56520: Update dependency versions

2017-02-10 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165153 --- It looks like org.apache.geode.internal.cache.tier.sockets.comman

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Kirk Lund
> On Feb. 10, 2017, 12:24 a.m., Dan Smith wrote: > > Looks good - but I wonder if these are really all direct dependencies. Do > > we really have a direct dependency on bcel, for example? If not it seems > > like we shouldn't manually set the bcel version - we should let gradle pull > > whatev

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165033 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 10, 2017, 12:07

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165029 --- Ship it! Looks good - but I wonder if these are really all dire

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165028 --- Ship it! Ship It! - Kevin Duling On Feb. 9, 2017, 4:07 p.m.,

Review Request 56520: Update dependency versions

2017-02-09 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/ --- Review request for geode, Anthony Baker, anilkumar gingade, Bruce Schuchardt, Da