Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-09 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/ --- (Updated Feb. 9, 2017, 4:02 p.m.) Review request for geode and Dan Smith. Cha

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/#review164820 --- I don't think logging something and continuing is the appropriate

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/ --- (Updated Feb. 8, 2017, 8:57 p.m.) Review request for geode and Dan Smith. Cha

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/ --- (Updated Feb. 8, 2017, 8:12 p.m.) Review request for geode and Dan Smith. Cha

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Bruce Schuchardt
> On Feb. 8, 2017, 7:44 p.m., Dan Smith wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java, > > line 155 > > > > > > Is this method still needed? loadProperties() isn't n

Re: Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/#review164748 --- geode-core/src/test/java/org/apache/geode/test/dunit/standalone/V

Review Request 56457: GEODE-2433 Backwards compatibility tests are not actually running

2017-02-08 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/ --- Review request for geode and Dan Smith. Bugs: GEODE-2433 https://issues.apa