Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-16 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/#review161800 --- Ship it! Ship It! - xiaojian zhou On Jan. 16, 2017, 7:37 p.m

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-16 Thread nabarun nag
> On Jan. 12, 2017, 5:26 p.m., Dan Smith wrote: > > I'd say actually get rid of the distributed member id part and just keep > > the name. > > > > Also, I don't think it's good practice to look up a singleton inside the > > constructor for LuceneIndexDetails. It would be better just pass the s

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-16 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/ --- (Updated Jan. 16, 2017, 7:37 p.m.) Review request for geode, Barry Oglesby, Jas

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-16 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/ --- (Updated Jan. 16, 2017, 7:14 p.m.) Review request for geode, Barry Oglesby, Jas

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-12 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/#review161458 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

Re: Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-12 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/#review161394 --- I'd say actually get rid of the distributed member id part and jus

Review Request 55442: GEODE-2273: Adding a server column to the Lucene index stat

2017-01-11 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55442/ --- Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian zh