Re: backward-compatibility testing

2017-01-19 Thread Bruce Schuchardt
It would be nice to know if a test is going to use an old version. Then we could boot the appropriate locator for it. I don't have anything like that implemented yet - there is still only one locator prestarted by the DUnit launcher. Le 1/19/2017 à 1:30 PM, Dan Smith a écrit : Does this mean

Re: backward-compatibility testing

2017-01-19 Thread Roman Shaposhnik
This is very interesting and it reminds me to ask this: how separable do you think DUnit could be from Geode? I'm thinking that it could be very useful in other Java-based distributed projects around ASF. Thanks, Roman. On Wed, Jan 18, 2017 at 3:11 PM, Bruce Schuchardt wrote: > I've extended th

Re: backward-compatibility testing

2017-01-19 Thread Dan Smith
> > The restriction on letting old-version members join is for rolling upgrade > and has been in Geode & GemFire for a long time. It gives us some > assurance that we can enable new distributed algorithms and stop using old > algorithms. We ran into that requirement when we altered distributed > l

Re: backward-compatibility testing

2017-01-19 Thread Bruce Schuchardt
Right, we don't allow it. That's what this email thread is about, Anil. Le 1/19/2017 à 12:16 PM, Anilkumar Gingade a écrit : any test starting a peer cache using an old version of Geode must create its own old-version Locator Bruce, we don't allow/recommend starting old versions of locator or

Re: backward-compatibility testing

2017-01-19 Thread Anilkumar Gingade
>> any test starting a peer cache using an old version of Geode must create its own old-version Locator Bruce, we don't allow/recommend starting old versions of locator or peers when the rolling upgrade is started, right? -Anil. On Thu, Jan 19, 2017 at 11:06 AM, Bruce Schuchardt wrote: > One wa

Re: backward-compatibility testing

2017-01-19 Thread Bruce Schuchardt
One way to do this would be to have the DUnit Locator run the oldest version of Geode that we want to test with. For now that would be 1.0.0-incubating. Any test that needs to exercise newer algorithms involving a Locator would need to launch one of its own. Does that sound acceptable? Le 1

Re: backward-compatibility testing

2017-01-19 Thread Bruce Schuchardt
Thanks Dan. I'm not sure we want to keep the change I made to the Locator. The restriction on letting old-version members join is for rolling upgrade and has been in Geode & GemFire for a long time. It gives us some assurance that we can enable new distributed algorithms and stop using old a

Re: backward-compatibility testing

2017-01-19 Thread Dan Smith
+1 This is great Bruce! I really like this approach of being able to write tests and have them run with some members with a different version. I think with this framework we should be able to just extend existing tests with subclasses that override the version of some of the VMs which I think is a

Re: backward-compatibility testing

2017-01-19 Thread Anthony Baker
> On Jan 18, 2017, at 3:11 PM, Bruce Schuchardt wrote: > > I've extended the distributedTest framework to let us do > backward-compatibility testing. Once it is reviewed and committed people > will be needed to modify existing tests to run against multiple versions of > Geode. > > Here is t

Re: backward-compatibility testing

2017-01-18 Thread William Markito Oliveira
Huge +1 Sent from my iPhone > On Jan 18, 2017, at 5:45 PM, Michael Stolz wrote: > > +1 I like this > > -- > Mike Stolz > Principal Engineer, GemFire Product Manager > Mobile: 631-835-4771 > > On Wed, Jan 18, 2017 at 6:22 PM, Udo Kohlmeyer > wrote: > >> +1 Nice work Bruce >> >> >> >>> On

Re: backward-compatibility testing

2017-01-18 Thread Michael Stolz
+1 I like this -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: 631-835-4771 On Wed, Jan 18, 2017 at 6:22 PM, Udo Kohlmeyer wrote: > +1 Nice work Bruce > > > > On 1/18/17 15:11, Bruce Schuchardt wrote: > >> I've extended the distributedTest framework to let us do >> backward-co

Re: backward-compatibility testing

2017-01-18 Thread Udo Kohlmeyer
+1 Nice work Bruce On 1/18/17 15:11, Bruce Schuchardt wrote: I've extended the distributedTest framework to let us do backward-compatibility testing. Once it is reviewed and committed people will be needed to modify existing tests to run against multiple versions of Geode. Here is the RB r