Thanks Kirk!.
Cheers.
On Tue, Sep 18, 2018 at 5:51 PM Kirk Lund wrote:
> I reviewed your changes and added approval. Thanks Juan!
>
> On Tue, Sep 18, 2018 at 12:46 AM, Juan José Ramos
> wrote:
>
> > Hello Jinmei and Dan,
> >
> > Thanks both for the reply!!.
> > Regarding pull 2250, I think the
I reviewed your changes and added approval. Thanks Juan!
On Tue, Sep 18, 2018 at 12:46 AM, Juan José Ramos wrote:
> Hello Jinmei and Dan,
>
> Thanks both for the reply!!.
> Regarding pull 2250, I think the changes requested by Galen are outdated
> now, but I'll ping him directly in the *pull req
Hello Jinmei and Dan,
Thanks both for the reply!!.
Regarding pull 2250, I think the changes requested by Galen are outdated
now, but I'll ping him directly in the *pull request * anyway to be sure.
Best regards.
On Mon, Sep 17, 2018 at 5:37 PM Dan Smith wrote:
> Hi Juan,
>
> Great questions! I
Hi Juan,
Great questions! I agree with what Jinmei said - go ahead and merge if you
have:
1) at least one approval
2) No changes requested
3) Checks are passing
The "at least one review" part is somewhat subjective, if you feel the PR
is complicated and you want more reviews, feel free to ask th
I believe you can go ahead. :-)
The way I see it, you can merge a PR when all three are satisfied:
1) you have the privilege to merge it (the button is activated for you to
push).
2) The PR is approved by a least one reviewer.
3) all checks passed.
Thanks!
On Mon, Sep 17, 2018, 3:48 AM Ju@N wr
