Re: Reviews and Conflicts in Pull Requests

2018-05-23 Thread Juan José Ramos
Hello Bruce, Sounds good to me, thanks for the quick reply!. Best regards. On Tue, May 22, 2018 at 4:44 PM Bruce Schuchardt wrote: > I don't think the "single commit" notion is even a good one for an > original PR. I've discussed this with other people and we think it's > okay for the PR to h

Re: Reviews and Conflicts in Pull Requests

2018-05-22 Thread Bruce Schuchardt
I don't think the "single commit" notion is even a good one for an original PR.  I've discussed this with other people and we think it's okay for the PR to have multiple commits if they serve different purposes such as renaming variables or restructuring code before attacking a problem.  Likewi