Re: Review Request 59849: add StringPrefixPartitionResolver

2017-06-06 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59849/#review177074 --- Ship it! Ship It! - Eric Shu On June 6, 2017, 6:54 p.m., Dar

Re: Review Request 59849: add StringPrefixPartitionResolver

2017-06-06 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59849/ --- (Updated June 6, 2017, 11:54 a.m.) Review request for geode, Eric Shu and Lynn

Re: Review Request 59849: add StringPrefixPartitionResolver

2017-06-06 Thread Darrel Schneider
> On June 6, 2017, 11:17 a.m., Eric Shu wrote: > > geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java > > Lines 60 (patched) > > > > > > Does getName() needs the Delimiter bei

Re: Review Request 59849: add StringPrefixPartitionResolver

2017-06-06 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59849/#review177064 --- geode-core/src/main/java/org/apache/geode/cache/partition/StringP