Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169795 --- - Ken Howe On March 17, 2017, 6:48 p.m., Jinmei Liao wrote: > >

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169799 --- - Ken Howe On March 17, 2017, 6:48 p.m., Jinmei Liao wrote: > >

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-22 Thread Kirk Lund
> On March 20, 2017, 8:48 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/internal/logging/log4j/LogWriterLogger.java > > Line 1332 (original) > > > > > > The mapping in the old LogWriterLogger d

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169524 --- Ship it! Ship It! - Ken Howe On March 17, 2017, 6:48 p.m., J

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-20 Thread Jinmei Liao
> On March 20, 2017, 8:48 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/internal/logging/log4j/LogWriterLogger.java > > Line 1332 (original) > > > > > > The mapping in the old LogWriterLogger d

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-20 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169505 --- Ship it! Ship It! - Kevin Duling On March 17, 2017, 11:48 a.

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-20 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169504 --- Ship it! This looks like a good first pass. As a next step, I

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169498 --- Partial review (through LogWritereLogger.java) geode-core/src/ma

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

2017-03-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/ --- (Updated March 17, 2017, 6:48 p.m.) Review request for geode, Jared Stewart, Ke